bugfix authority docs #128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnsonjben
approved these changes
Nov 26, 2024
| @@ -3,8 +3,9 @@ DOCS_SRC = docs-src | |||
| DOCS = $(DOCS_SRC)/docs | |||
| DOCS_OUT = $(DOCS_SRC)/out | |||
| API_DOCS = $(BUILD)/api | |||
| DOCS_SERVER := "http://localhost:5000" # Use this value as the docserver for a locally hosted baldur instance | |||
| # DOCS_SERVER := "http://localhost:8080" # Use this value as the docserver for a locally hosted api gateway instance | |||
| DOCS_SERVER = "https://api.us.code42.com" # Use this value to run against production api-gateway | |||
There was a problem hiding this comment.
FYI this gets set by the developer portal deployment repo, for core-int + prod:
https://stash.corp.code42.com/projects/DT/repos/developer-portal-deployment/browse/terraform/main.tf#108
There was a problem hiding this comment.
Im curious if this is set explicitly here, if that passed in param value from the developer portal deployment will still work? Suppose it would also be nice to throw a comment in this location saying ^ that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUGFIX: prevent the authority's File object definition from clobbering ffs'