Skip to content

chore: Upgrade ruby to 3.4.4 #2219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .ruby-version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
3.2.2
3.4.4
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM ruby:3.2.2
FROM ruby:3.4.4

# Default node version on apt is old. This makes sure a recent version is installed
# This step also runs apt-get update
Expand Down
9 changes: 8 additions & 1 deletion Gemfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
source 'https://rubygems.org'
ruby '3.2.2'
ruby '3.4.4'

gem 'rails', '7.0.8.1'
# The original asset pipeline for Rails [https://github.com/rails/sprockets-rails]
Expand All @@ -8,21 +8,27 @@ gem 'sprockets-rails'
gem 'bootsnap', require: false

gem 'acts-as-taggable-on'
gem 'benchmark' # LOCKED: Added because of activesupport 7.0
gem 'bigdecimal' # LOCKED: Added because of activesupport 7.0
gem 'carrierwave'
gem 'carrierwave-ftp', github: 'luan/carrierwave-ftp', ref: '5481c13', require: 'carrierwave/storage/sftp'
gem 'cocoon'
gem "csv" # LOCKED: csv was loaded from the standard library, but is not part of the default gems starting from Ruby 3.4.0. Due to config/application.rb
gem 'delayed_job'
gem 'delayed_job_active_record'
gem 'drb' # LOCKED: Added because of pry-remote
gem 'font_awesome5_rails'
gem 'bootstrap', '~> 5'
gem 'friendly_id'
gem 'haml'
gem 'high_voltage'
gem 'irb' # LOCKED: Added because of byebug
gem 'jquery-rails'
gem 'jquery-ui-rails'

# Use Active Storage variant
gem 'image_processing', '~> 1.2'
gem 'mutex_m' # LOCKED: Added because of activesupport 7.0
gem 'nokogiri'
gem 'omniauth'
gem 'omniauth-github'
Expand All @@ -33,6 +39,7 @@ gem 'premailer-rails'

gem 'pundit'
gem 'rails4-autocomplete'
gem 'reline' # LOCKED: Added because of readline is not part of Ruby 3.5.0
gem 'rolify'
# Use Sass to process CSS
gem 'sassc-rails'
Expand Down
34 changes: 32 additions & 2 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -84,10 +84,12 @@ GEM
autoprefixer-rails (10.4.16.0)
execjs (~> 2)
base64 (0.2.0)
benchmark (0.4.1)
better_errors (2.10.1)
erubi (>= 1.0.0)
rack (>= 0.9.0)
rouge (>= 1.0.0)
bigdecimal (3.2.2)
bindex (0.8.1)
binding_of_caller (1.0.1)
debug_inspector (>= 1.2.0)
Expand Down Expand Up @@ -137,6 +139,7 @@ GEM
crass (1.0.6)
css_parser (1.14.0)
addressable
csv (3.3.5)
database_cleaner (2.0.2)
database_cleaner-active_record (>= 2, < 3)
database_cleaner-active_record (2.1.0)
Expand All @@ -157,6 +160,8 @@ GEM
dotenv (= 3.1.0)
railties (>= 6.1)
double-bag-ftps (0.1.4)
drb (2.2.3)
erb (5.0.2)
erubi (1.13.1)
execjs (2.10.0)
fabrication (2.31.0)
Expand Down Expand Up @@ -195,6 +200,11 @@ GEM
actionpack (>= 6.0.0)
activesupport (>= 6.0.0)
railties (>= 6.0.0)
io-console (0.8.1)
irb (1.15.2)
pp (>= 0.6.0)
rdoc (>= 4.0.0)
reline (>= 0.4.2)
jbuilder (2.12.0)
actionview (>= 5.0.0)
activesupport (>= 5.0.0)
Expand Down Expand Up @@ -235,6 +245,7 @@ GEM
minitest (5.25.5)
msgpack (1.7.5)
multi_xml (0.6.0)
mutex_m (0.3.0)
net-http (0.4.1)
uri
net-imap (0.4.20)
Expand Down Expand Up @@ -283,6 +294,8 @@ GEM
pickadate-rails (3.5.6.0)
railties (>= 3.1.0)
popper_js (2.11.8)
pp (0.6.2)
prettyprint
premailer (1.21.0)
addressable
css_parser (>= 1.12.0)
Expand All @@ -291,6 +304,7 @@ GEM
actionmailer (>= 3)
net-smtp
premailer (~> 1.7, >= 1.7.9)
prettyprint (0.2.0)
pry (0.14.2)
coderay (~> 1.1)
method_source (~> 1.0)
Expand All @@ -302,6 +316,9 @@ GEM
pry-remote (0.1.8)
pry (~> 0.9)
slop (~> 3.0)
psych (5.2.6)
date
stringio
public_activity (3.0.1)
actionpack (>= 6.1.0)
activerecord (>= 6.1)
Expand Down Expand Up @@ -361,7 +378,12 @@ GEM
rb-fsevent (0.11.2)
rb-inotify (0.10.1)
ffi (~> 1.0)
rdoc (6.14.2)
erb
psych (>= 4.0.0)
regexp_parser (2.10.0)
reline (0.6.2)
io-console (~> 0.5)
rexml (3.4.1)
rolify (6.0.1)
rollbar (3.6.0)
Expand Down Expand Up @@ -456,6 +478,7 @@ GEM
ssrf_filter (1.1.2)
stimulus-rails (1.3.4)
railties (>= 6.0.0)
stringio (3.1.7)
stripe (9.0.0)
temple (0.10.3)
terser (1.2.4)
Expand Down Expand Up @@ -496,7 +519,9 @@ PLATFORMS

DEPENDENCIES
acts-as-taggable-on
benchmark
better_errors
bigdecimal
binding_of_caller
bootsnap
bootstrap (~> 5)
Expand All @@ -507,10 +532,12 @@ DEPENDENCIES
chosen-rails
cocoon
commonmarker
csv
database_cleaner
delayed_job
delayed_job_active_record
dotenv-rails
drb
fabrication
faker
faraday
Expand All @@ -522,12 +549,14 @@ DEPENDENCIES
icalendar
image_processing (~> 1.2)
importmap-rails
irb
jbuilder
jquery-rails
jquery-ui-rails
launchy
letter_opener
listen (~> 3.9)
mutex_m
nokogiri
omniauth
omniauth-github
Expand All @@ -547,6 +576,7 @@ DEPENDENCIES
rails-html-sanitizer (~> 1.6.1)
rails4-autocomplete
rails_12factor
reline
rolify
rollbar
rspec-collection_matchers
Expand All @@ -572,7 +602,7 @@ DEPENDENCIES
web-console (>= 4.1.0)

RUBY VERSION
ruby 3.2.2p137
ruby 3.4.4

BUNDLED WITH
2.4.17
2.6.7
10 changes: 5 additions & 5 deletions native-installation-instructions.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,20 +16,20 @@ These are the original instructions for natively installing the app to your mach

## Set up a Ruby Environment

You will need to install Ruby 3.2.2 using RVM or rbenv.
You will need to install Ruby 3.4.4 using RVM or rbenv.

### Option 1: Using [rvm](https://rvm.io/rvm/install)

```bash
CPPFLAGS=-DUSE_FFI_CLOSURE_ALLOC rvm install 3.2.2
CPPFLAGS=-DUSE_FFI_CLOSURE_ALLOC rvm install 3.4.4
```
We need to set the CPPFLAGS env variable to be able to install Ruby 3.2.2 on M1 Mac machines. See more: [https://github.com/ffi/ffi/issues/869#issuecomment-1233000037](https://github.com/ffi/ffi/issues/869#issuecomment-1233000037)
We need to set the CPPFLAGS env variable to be able to install Ruby 3.4.4 on M1 Mac machines. See more: [https://github.com/ffi/ffi/issues/869#issuecomment-1233000037](https://github.com/ffi/ffi/issues/869#issuecomment-1233000037)

### Option 2: Using [rbenv](https://github.com/sstephenson/rbenv) and [ruby-build](https://github.com/sstephenson/ruby-build)

```bash
rbenv install 3.2.2
rbenv global 3.2.2
rbenv install 3.4.4
rbenv global 3.4.4
```

## Install and run PostgreSQL
Expand Down
Loading