fixed minor TS typing issues in class Result and output.result #5252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [playwright](https://github.com/microsoft/playwright) from 1.53.0 to 1.54.1. - [Release notes](https://github.com/microsoft/playwright/releases) - [Commits](microsoft/playwright@v1.53.0...v1.54.1) --- updated-dependencies: - dependency-name: playwright dependency-version: 1.54.1 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
--- updated-dependencies: - dependency-name: "@eslint/js" dependency-version: 9.31.0 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [expect](https://github.com/jestjs/jest/tree/HEAD/packages/expect) from 29.7.0 to 30.0.4. - [Release notes](https://github.com/jestjs/jest/releases) - [Changelog](https://github.com/jestjs/jest/blob/main/CHANGELOG.md) - [Commits](https://github.com/jestjs/jest/commits/v30.0.4/packages/expect) --- updated-dependencies: - dependency-name: expect dependency-version: 30.0.4 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [graphql](https://github.com/graphql/graphql-js) from 16.10.0 to 16.11.0. - [Release notes](https://github.com/graphql/graphql-js/releases) - [Commits](graphql/graphql-js@v16.10.0...v16.11.0) --- updated-dependencies: - dependency-name: graphql dependency-version: 16.11.0 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [electron](https://github.com/electron/electron) from 37.1.0 to 37.2.3. - [Release notes](https://github.com/electron/electron/releases) - [Changelog](https://github.com/electron/electron/blob/main/docs/breaking-changes.md) - [Commits](electron/electron@v37.1.0...v37.2.3) --- updated-dependencies: - dependency-name: electron dependency-version: 37.2.3 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [axios](https://github.com/axios/axios) from 1.8.4 to 1.11.0. - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md) - [Commits](axios/axios@v1.8.4...v1.11.0) --- updated-dependencies: - dependency-name: axios dependency-version: 1.11.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…deceptjs#5046) Bumps [typedoc-plugin-markdown](https://github.com/typedoc2md/typedoc-plugin-markdown/tree/HEAD/packages/typedoc-plugin-markdown) from 4.7.0 to 4.7.1. - [Release notes](https://github.com/typedoc2md/typedoc-plugin-markdown/releases) - [Changelog](https://github.com/typedoc2md/typedoc-plugin-markdown/blob/main/packages/typedoc-plugin-markdown/CHANGELOG.md) - [Commits](https://github.com/typedoc2md/typedoc-plugin-markdown/commits/[email protected]/packages/typedoc-plugin-markdown) --- updated-dependencies: - dependency-name: typedoc-plugin-markdown dependency-version: 4.7.1 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…s#5041) Bumps [browser-actions/setup-chrome](https://github.com/browser-actions/setup-chrome) from 1 to 2. - [Release notes](https://github.com/browser-actions/setup-chrome/releases) - [Changelog](https://github.com/browser-actions/setup-chrome/blob/master/CHANGELOG.md) - [Commits](browser-actions/setup-chrome@v1...v2) --- updated-dependencies: - dependency-name: browser-actions/setup-chrome dependency-version: '2' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [typedoc](https://github.com/TypeStrong/TypeDoc) from 0.28.7 to 0.28.10. - [Release notes](https://github.com/TypeStrong/TypeDoc/releases) - [Changelog](https://github.com/TypeStrong/typedoc/blob/master/CHANGELOG.md) - [Commits](TypeStrong/typedoc@v0.28.7...v0.28.10) --- updated-dependencies: - dependency-name: typedoc dependency-version: 0.28.10 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* fix: hook exit code * Update asyncWrapper.js Co-authored-by: Copilot <[email protected]> * Update asyncWrapper.js Co-authored-by: Copilot <[email protected]> * Update asyncWrapper.js Co-authored-by: Copilot <[email protected]> * Update asyncWrapper.js Co-authored-by: Copilot <[email protected]> * Update asyncWrapper.js * Update asyncWrapper.js Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Copilot <[email protected]>
…odeceptjs#5072) * fix share workers * fix share workers
Bumps [actions/checkout](https://github.com/actions/checkout) from 4 to 5. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4...v5) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [tsd](https://github.com/tsdjs/tsd) from 0.32.0 to 0.33.0. - [Release notes](https://github.com/tsdjs/tsd/releases) - [Commits](tsdjs/tsd@v0.32.0...v0.33.0) --- updated-dependencies: - dependency-name: tsd dependency-version: 0.33.0 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…deceptjs#5067) Bumps [typedoc-plugin-markdown](https://github.com/typedoc2md/typedoc-plugin-markdown/tree/HEAD/packages/typedoc-plugin-markdown) from 4.7.1 to 4.8.1. - [Release notes](https://github.com/typedoc2md/typedoc-plugin-markdown/releases) - [Changelog](https://github.com/typedoc2md/typedoc-plugin-markdown/blob/main/packages/typedoc-plugin-markdown/CHANGELOG.md) - [Commits](https://github.com/typedoc2md/typedoc-plugin-markdown/commits/[email protected]/packages/typedoc-plugin-markdown) --- updated-dependencies: - dependency-name: typedoc-plugin-markdown dependency-version: 4.8.1 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* release 3.7.4
…Timeout` value at the end of test suite (codeceptjs#5077) * Initial plan * Changes before error encountered Co-authored-by: kobenguyent <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: kobenguyent <[email protected]>
* Initial plan * Changes before error encountered Co-authored-by: kobenguyent <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: kobenguyent <[email protected]>
codeceptjs#5082) * Initial plan * Fix JUnit XML test case name inconsistency in scenario retries Co-authored-by: kobenguyent <[email protected]> * Improve edge case handling for empty suite titles in cloned tests Co-authored-by: kobenguyent <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: kobenguyent <[email protected]>
* fix: TestCafe_test.js * Fix TestCafe form submission timeout with efficient polling mechanism (codeceptjs#5080) * Initial plan * Fix failed TestCafe tests by skipping doubleClick test * Update testcafe.yml * Update testcafe.yml * Update TestCafe_test.js * Update TestCafe_test.js * Changes before error encountered Co-authored-by: kobenguyent <[email protected]> * Fix TestCafe form submission timeout in CI environments * Improve TestCafe form submission timeout handling with polling mechanism Co-authored-by: kobenguyent <[email protected]> * Improve TestCafe form submission timeout with efficient polling mechanism Co-authored-by: kobenguyent <[email protected]> * Changes before error encountered Co-authored-by: kobenguyent <[email protected]> * Changes before error encountered Co-authored-by: kobenguyent <[email protected]> * Changes before error encountered Co-authored-by: kobenguyent <[email protected]> * Update testcafe.yml * fix: Chrome popup causes problems with TestCafe --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: kobenguyent <[email protected]> Co-authored-by: kobenguyent <[email protected]> --------- Co-authored-by: Copilot <[email protected]>
* Initial plan * Changes before error encountered Co-authored-by: kobenguyent <[email protected]> * Add TypeScript types for Feature.only method * Changes before error encountered Co-authored-by: kobenguyent <[email protected]> * Fix TypeScript test expectations for hook return types Co-authored-by: kobenguyent <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: kobenguyent <[email protected]>
* Initial plan * Changes before error encountered Co-authored-by: kobenguyent <[email protected]> * Changes before error encountered Co-authored-by: kobenguyent <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: kobenguyent <[email protected]>
* fix: wrong stats when running with workers * fix: failed runner tests
…js#5192) * feat: add support for Playwright storageState configuration and helper methods * doc : run docs --------- Co-authored-by: kobenguyent <[email protected]>
…odeceptjs#5222) * fixed: types: PupeteerConfig.waitForNavigation can be an array * restore original formatting * fix Puppeteer links * fixed more links
* enhance workers cli log * fix: make worker enhancements backward compatible with all test suites - Made feature name display conditional (only in workers mode) - Preserved run-multiple process format [X.suite:browser] - Updated test expectations to match new enhanced format - All test suites now passing (221 runner + 477 unit tests) Changes: - lib/output.js: Conditional feature names + run-multiple detection - test/unit/output_test.js: Updated worker badge test expectation - test/runner/run_workers_test.js: Updated 3 test expectations Fixes codeceptjs#5234
* fixed: typings for class Result * fix docs for getters
* mock server * mock server * lint fix * fix: acceptance tests cannot access mock server * fix: acceptance tests cannot access mock server * fix: flaky timeout test
* address HTML reporter issues * address HTML reporter issues * fix UTs and lint issue
…ils: TypeError: Chaining cycle detected for promise Fixes codeceptjs#4844) (codeceptjs#5276)
* Fix: preserve global timeout with BeforeSuite hook * test: clarify feature name for global timeout with BeforeSuite * chore: remove unused plugins field from beforeSuiteTimeout config
kobenguyent
reviewed
Oct 29, 2025
docs/plugins.md
Outdated
| ## reportData | ||
| TypeScript: Explicitly type reportData arrays as any\[] to avoid 'never' errors |
Collaborator
There was a problem hiding this comment.
@danielrentz I'm not sure if the \ here is intended?
Contributor
Author
There was a problem hiding this comment.
@kobenguyent As mentioned above... "Unrelated changes in plugins.md have been auto-generated by npm run docs."
No idea what to do about it. Even the git commit hooks manipulate these files, and confusingly in another way than the local build scripts. Will try to remove this change.
Another question... You changed the target branch from 3.x to 4.x a few weeks ago ... I did not notice this and thought I did that by mistake somehow, and therefore changed it back to 3.x. I remember that the PR did show dozens or hundrets of changed files when it has targeted 4.x. What is the desired way here? Is 3.x dead, and work continues in 4.x?
Collaborator
There was a problem hiding this comment.
Hi, great news! The 4.x version is now synced with 3.x. As you know, 4.x is an ESM migration, and I believe we’d like to merge into 4.x as much as possible, rather than keeping both 2 branches separate. Perhaps @DavertMik has a different perspective, and I’d love to hear your thoughts. Thanks!
…e "result" object) (codeceptjs#5233)
…odeceptjs#5211) * Update reports.md: use "reporter" option instead of CLI * typo * add config-only variant as an alternative
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/Description of the PR
Two small fixes for Typescript typings:
output.resultmisses a declaration for the optional parameter "failedHooks".class Resultmay contain numbers or strings. The exact type for a single failure report is[string, number, string, string, string]but that is not possible to declare with vanilla JSDoc. Added typedefFailureas string/number array, and replacedstring[]with the new type.Unrelated changes in
plugins.mdhave been auto-generated bynpm run docs.Applicable helpers:
Applicable plugins:
Type of change
Checklist:
npm run docs)npm run lint)npm test)