Fixed signupPage #33

ghost · 2020-06-06T12:02:26Z

No description provided.

tayormi · 2020-06-06T12:22:59Z

Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 35
- Added 20

See the complete overview on Codacy

tayormi · 2020-06-06T12:23:10Z

css/signup.css

-
-.submit::after {
-  content: '!';
+/**SignUpForm*/


Issue found: Expected whitespace after "/*" (comment-whitespace-inside)

tayormi · 2020-06-06T12:23:11Z

css/signup.css

+  padding: 0.6rem 0;
+  border-radius: 20px;
+}


Issue found: Expected empty line before rule (rule-empty-line-before)

tayormi · 2020-06-06T12:23:12Z

css/signup.css

-.info {
-  font-size: 13px;
-  font-weight: 600;
+#signUpInfo .welcome,


Issue found: Expected empty line before rule (rule-empty-line-before)

tayormi · 2020-06-06T12:23:13Z

css/signup.css

  display: flex;
  justify-content: space-between;
  width: 100%;
  margin-top: 1rem;
 }
-.nameInputGroup label:nth-child(2) {
-  padding-left:1rem;
-} 


Issue found: Expected empty line before rule (rule-empty-line-before)

tayormi · 2020-06-06T12:23:13Z

css/signup.css

-  text-align: center;
-  margin-top: 1rem;
-  font-size: 12px;
+#signUpInfo .welcomeSignUp::after {


Issue found: Expected empty line before rule (rule-empty-line-before)

tayormi · 2020-06-06T12:23:14Z

css/signup.css

 }
-.signUp {
-  padding:0rem 0.2rem;
+.welcomeSignUp {


Issue found: Expected empty line before rule (rule-empty-line-before)

tayormi · 2020-06-06T12:23:15Z

css/signup.css

+  text-align: center;
+  margin-top: 1.25rem;
+}


Issue found: Expected empty line before rule (rule-empty-line-before)

tayormi · 2020-06-06T12:23:16Z

css/signup.css

+  margin-top: 2.5%;
+  margin-left: 8.5%;
+}
+/**SignUpInfo**/


Issue found: Expected whitespace after "/*" (comment-whitespace-inside)

tayormi · 2020-06-06T12:23:17Z

css/signup.css

+  border: transparent;
+  padding: 30px 50px;
+}
+.img#logo {


Issue found: Expected empty line before rule (rule-empty-line-before)

tayormi · 2020-06-06T12:23:17Z

css/signup.css

-  margin-top: 0.8rem;
-  padding:0.6rem 0;
-  border-radius: 10px;
+img#illustration {


Issue found: Expected empty line before rule (rule-empty-line-before)

tayormi · 2020-06-06T12:23:18Z

css/signup.css

+  margin-top: 1rem;
+  font-size: 12px;
+}


Issue found: Expected empty line before rule (rule-empty-line-before)

tayormi · 2020-06-06T12:23:19Z

css/signup.css

 }
-.nameInputGroup {
+#nameInputGroup {


Issue found: Expected empty line before rule (rule-empty-line-before)

tayormi · 2020-06-06T12:23:20Z

css/signup.css

+.signIn .link {
+  padding-left: 0.15rem;
+}


Issue found: Expected empty line before rule (rule-empty-line-before)

tayormi · 2020-06-06T12:23:21Z

css/signup.css

+  margin-top: 2.5%;
+  margin-left: 8.5%;
+}
+/**SignUpInfo**/


Issue found: Expected empty line before comment (comment-empty-line-before)

tayormi · 2020-06-06T12:23:22Z

css/signup.css

-
-.submit::after {
-  content: '!';
+/**SignUpForm*/


Issue found: Expected empty line before comment (comment-empty-line-before)

tayormi · 2020-06-06T12:23:23Z

css/signup.css

-  color:#1F59BB;
-  text-transform: capitalize;
-  font-weight: 400;
+#signUpWrapper {


Issue found: Expected empty line before rule (rule-empty-line-before)

tayormi · 2020-06-06T12:23:24Z

css/signup.css

-  background:rgba(31, 89, 187, 0.05);
-  border-radius:5px;
-  height:1.8rem;
+.input {


Issue found: Expected empty line before rule (rule-empty-line-before)

tayormi · 2020-06-06T12:23:24Z

css/signup.css

-.signIn {
-  text-align: center;
-  margin-top: 1.2rem;
+form#signUpForm {


Issue found: Expected empty line before rule (rule-empty-line-before)

tayormi · 2020-06-06T12:23:25Z

css/signup.css

  width: 100%;
  margin-top: 0.5rem;
 }
-label {
+.label {


Issue found: Expected empty line before rule (rule-empty-line-before)

tayormi · 2020-06-06T12:23:26Z

css/signup.css

 }
-.signUp {
-  padding:0rem 0.2rem;
+.welcomeSignUp {


Issue found: Expected selector ".welcomeSignUp" to come before selector "#signUpInfo .welcomeSignUp" (no-descending-specificity)

tayormi · 2020-06-08T00:36:09Z

Hi Karen. There is a conflict with the signin.html file, can you fix it?

ghost · 2020-06-08T13:04:14Z

Ill check it right now

…

On Mon, Jun 8, 2020 at 1:36 AM Temitope Ajiboye ***@***.***> wrote: Hi Karen. There is a conflict with the signin.html file, can you fix it? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#33 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ANRT6JGNOPZJCXJRBNE3JLTRVQXALANCNFSM4NV5NOBQ> .

Karen Efereyan added 3 commits May 28, 2020 23:06

Linked sign up page on sign in page

80044a6

Fixed signUp page

97ded5a

Properly linked signUp and signIn Pages

1c46cd3

tayormi reviewed Jun 6, 2020

View reviewed changes

css/signup.css

.submit::after {

content: '!';

/**SignUpForm*/

Copy link

Member

tayormi Jun 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue found: Expected whitespace after "/*" (comment-whitespace-inside)

tayormi reviewed Jun 6, 2020

View reviewed changes

css/signup.css

padding: 0.6rem 0;

border-radius: 20px;

}

Copy link

Member

tayormi Jun 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue found: Expected empty line before rule (rule-empty-line-before)

tayormi reviewed Jun 6, 2020

View reviewed changes

css/signup.css

text-align: center;

margin-top: 1.25rem;

}

Copy link

Member

tayormi Jun 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue found: Expected empty line before rule (rule-empty-line-before)

tayormi reviewed Jun 6, 2020

View reviewed changes

css/signup.css

margin-top: 1rem;

font-size: 12px;

}

Copy link

Member

tayormi Jun 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue found: Expected empty line before rule (rule-empty-line-before)

tayormi reviewed Jun 6, 2020

View reviewed changes

css/signup.css

}

.nameInputGroup {

#nameInputGroup {

Copy link

Member

tayormi Jun 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue found: Expected empty line before rule (rule-empty-line-before)

tayormi reviewed Jun 6, 2020

View reviewed changes

css/signup.css

.signIn .link {

padding-left: 0.15rem;

}

Copy link

Member

tayormi Jun 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue found: Expected empty line before rule (rule-empty-line-before)

tayormi reviewed Jun 6, 2020

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixed signupPage #33

Fixed signupPage #33

ghost commented Jun 6, 2020

tayormi commented Jun 6, 2020

tayormi Jun 6, 2020

tayormi Jun 6, 2020

tayormi Jun 6, 2020

tayormi Jun 6, 2020

tayormi Jun 6, 2020

tayormi Jun 6, 2020

tayormi Jun 6, 2020

tayormi Jun 6, 2020

tayormi Jun 6, 2020

tayormi Jun 6, 2020

tayormi Jun 6, 2020

tayormi Jun 6, 2020

tayormi Jun 6, 2020

tayormi Jun 6, 2020

tayormi Jun 6, 2020

tayormi Jun 6, 2020

tayormi Jun 6, 2020

tayormi Jun 6, 2020

tayormi Jun 6, 2020

tayormi Jun 6, 2020

tayormi commented Jun 8, 2020

ghost commented Jun 8, 2020 via email

Fixed signupPage #33

Are you sure you want to change the base?

Fixed signupPage #33

Conversation

ghost commented Jun 6, 2020

tayormi commented Jun 6, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tayormi commented Jun 8, 2020

ghost commented Jun 8, 2020 via email