Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubocop to 1.64.1 #369

Merged

Conversation

BrianHawley
Copy link

@BrianHawley BrianHawley commented Apr 23, 2024

  • General bundle update.
  • Update the docs too.
  • Add rubocop-rspec_rails because its cops have been moved out of rubocop-rspec; rubocop-capybara and rubocop-factory_bot were added earlier for the same reason.
  • Add rubocop-rails-omakase for those who want a less prescriptive rubocop config.
  • Add require "ostruct" to a couple test files using OpenStruct.

@BrianHawley
Copy link
Author

@fede-moya could you merge this one? It's just bundle update and rake docs:scrape.

@BrianHawley BrianHawley changed the title Update rubocop to 1.63.3 Update rubocop to 1.63.5 May 15, 2024
@BrianHawley BrianHawley force-pushed the updates_rubocop_1-63-3 branch 2 times, most recently from d560604 to 7291fef Compare May 21, 2024 14:55
@rebeccafae
Copy link

rebeccafae commented May 21, 2024

Sorry, I don't know of a better place to ask this. What is the process for getting a new channel version branch off of the beta so that we can have another locked version?

I found 2 issues, but they seem to get even less traction than the PRs.
#364
#370

@BrianHawley BrianHawley changed the title Update rubocop to 1.63.5 Update rubocop to 1.64.1 Jun 13, 2024
@BrianHawley BrianHawley force-pushed the updates_rubocop_1-63-3 branch 2 times, most recently from b67ac1f to 983a318 Compare June 18, 2024 17:16
- General bundle update.
- Update the docs too.
- Add rubocop-rspec_rails because its cops have been moved out of
  rubocop-rspec; rubocop-capybara and rubocop-factory_bot were added
  earlier for the same reason.
- Add rubocop-rails-omakase for those who want a less prescriptive
  rubocop config.
- Add `require "ostruct"` to a couple test files using OpenStruct.
@BrianHawley
Copy link
Author

BrianHawley commented Jul 1, 2024

@fede-moya could you merge this one? It includes fixes for Rails 7.1 projects, so it's a critical upgrade.

@fede-moya fede-moya merged commit 6ae8a4e into codeclimate:channel/beta Jul 1, 2024
1 check passed
@fede-moya
Copy link

Thanks, will release the change soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants