feat(ingest): binary-safe envelope parser for attachment items - #265
Merged
Conversation
- New parse_envelope_binary() works on raw bytes instead of text - Length-based read for attachment payloads (handles embedded \n, \x00, etc.) - ItemHeader struct for structured header parsing - find_newline() helper for byte scanning - Updated parse_envelope() entry point to use binary parser - parse_envelope_text() preserved for backward compat - 7 new tests: mixed items, binary round-trip, truncated, gzip, multi-attachment - 23/23 ingest tests pass Closes #245
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #245 · Parent: #233
Summary
Rewrite envelope parser to handle binary attachment payloads via length-delimited reads.
Key Changes
Tests: 23/23 ingest, all workspace tests pass