fix(ci): ubuntu-24.04 standard build for numkong GCC 14 - #963
Merged
Conversation
numkong 7.7.0 requires GCC 13+ for SIMD probes (AVX512-FP16, AMX, AVX10.2). ubuntu-22.04 ships GCC 11 which fails compilation. ubuntu-24.04 provides GCC 14 which handles all numkong probes correctly. No zigbuild, no cross-compiler — standard cargo build with system GCC. GLIBC 2.39 — narrow compatibility but Docker image covers older distros.
🔍 Cora AI Code Review✅ No issues found. Code looks good! Review powered by cora-code · BYOK · MIT |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Switch Linux build runners back to ubuntu-24.04 (standard build, no zigbuild).
Why
numkong 7.7.0 (transitive dep via
ort) requires GCC 13+ for SIMD probes:-mavx512fp16(Sapphire Rapids)-mamx-fp16(Granite Rapids)-mavx10.2-512(Diamond Rapids)-mavxvnniint8(Sierra Forest)Key insight: Before zigbuild was added (PR #951), builds ran on ubuntu-24.04 (originally ubuntu-latest) and succeeded. The zigbuild migration introduced failures. Going back to ubuntu-24.04 with standard
cargo buildshould restore the pre-zigbuild success.Changes
Compatibility
GLIBC 2.39 (Ubuntu 24.04+). For older distros, Docker image (Debian 12 based) is the recommended path.
Testing