Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ta): use bucket specified in config #1034

Merged
merged 2 commits into from
Dec 4, 2024
Merged

fix(ta): use bucket specified in config #1034

merged 2 commits into from
Dec 4, 2024

Conversation

joseph-sentry
Copy link
Contributor

we were previously using the bucket name hard coded in the Django settings instead of using the bucket name specified in the codecov installation config

we were previously using the bucket name hard coded in the Django
settings instead of using the bucket name specified in the codecov
installation config
@joseph-sentry joseph-sentry requested a review from a team December 4, 2024 15:30
@codecov-notifications
Copy link

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
codecov/settings_staging.py 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Copy link
Contributor

github-actions bot commented Dec 4, 2024

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

@joseph-sentry joseph-sentry added this pull request to the merge queue Dec 4, 2024
Merged via the queue into main with commit 591a7ab Dec 4, 2024
16 of 17 checks passed
@joseph-sentry joseph-sentry deleted the joseph/fix-ta branch December 4, 2024 16:04
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.00%. Comparing base (3813d1b) to head (dacfc02).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
codecov/settings_staging.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1034   +/-   ##
=======================================
  Coverage   96.00%   96.00%           
=======================================
  Files         828      828           
  Lines       19353    19353           
=======================================
  Hits        18579    18579           
  Misses        774      774           
Flag Coverage Δ
unit 92.25% <50.00%> (ø)
unit-latest-uploader 92.25% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants