Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Fix trial status resolver when status is None #1076

Merged
merged 2 commits into from
Jan 2, 2025

Conversation

rohitvinnakota-codecov
Copy link
Contributor

@rohitvinnakota-codecov rohitvinnakota-codecov commented Dec 31, 2024

Resolves the following error

None is not a valid TrialStatus\n\nGraphQL request:14:9\n13 | trialEndDate\n14 | trialStatus\n | ^\n15 | trialStartDate
...
File \"/app/graphql_api/types/plan/plan.py\", line 35, in resolve_trial_status\n return TrialStatus(plan_service.trial_status)\n

Copy link

codecov bot commented Dec 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.02%. Comparing base (24784ce) to head (854c88a).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1076   +/-   ##
=======================================
  Coverage   96.02%   96.02%           
=======================================
  Files         828      828           
  Lines       19461    19463    +2     
=======================================
+ Hits        18687    18689    +2     
  Misses        774      774           
Flag Coverage Δ
unit 92.30% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 92.30% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copy link
Contributor

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

@rohitvinnakota-codecov rohitvinnakota-codecov marked this pull request as ready for review December 31, 2024 15:49
@rohitvinnakota-codecov rohitvinnakota-codecov requested a review from a team as a code owner December 31, 2024 15:49
@rohitvinnakota-codecov rohitvinnakota-codecov added this pull request to the merge queue Jan 2, 2025
Merged via the queue into main with commit 15d2415 Jan 2, 2025
18 of 19 checks passed
@rohitvinnakota-codecov rohitvinnakota-codecov deleted the rvinnakota/trial-status-fix branch January 2, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants