dev: swap create to update_or_create when inserting plans/tiers #1120
Conversation
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
📢 Thoughts on this report? Let us know! |
|
✅ All tests successful. No failed tests were found. 📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Changes have been made to critical files, which contain lines commonly executed in production. Learn more ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #1120 +/- ##
==========================================
- Coverage 96.03% 95.68% -0.36%
==========================================
Files 837 750 -87
Lines 19766 14459 -5307
==========================================
- Hits 18983 13835 -5148
+ Misses 783 624 -159
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ajay-sentry
changed the title
| 5,2025-01-16 04:35:34.152 -0800,2025-01-24 11:35:42.724 -0800,10,"{""Includes 5 seats"",""$10 per additional seat"",""Unlimited public repositories"",""Unlimited private repositories"",""Priority Support""}",annually,true,Sentry Pro,5,,true,users-sentryy,5,price_1Mj1mMGlVGuVgOrkC0ORc6iW | ||
| 4,2025-01-16 04:34:33.867 -0800,2025-01-24 11:35:48.218 -0800,12,"{""Includes 5 seats"",""$10 per additional seat"",""Unlimited public repositories"",""Unlimited private repositories"",""Priority Support""}",monthly,true,Sentry Pro,5,,true,users-sentrym,5,price_1Mj1kYGlVGuVgOrk7jucaZAa | ||
| 3,2025-01-16 04:32:44.655 -0800,2025-01-24 11:36:09.660 -0800,10,"{""Configurable # of users"",""Unlimited public repositories"",""Unlimited private repositories"",""Priority Support""}",annually,true,Pro,,,true,users-pr-inappy,3,plan_H6P16wij3lUuxg | ||
| 2,2025-01-16 04:30:42.897 -0800,2025-01-24 11:36:14.651 -0800,12,"{""Configurable # of users"",""Unlimited public repositories"",""Unlimited private repositories"",""Priority Support""}",monthly,true,Pro,,,true,users-pr-inappm,3,plan_H6P3KZXwmAbqPS |
There was a problem hiding this comment.
these are junk values/non-prod right? can you change those last 2 to have price_ instead of plan?
There was a problem hiding this comment.
nah they're legit values 😅 We need them to actually checkout with stripe locally / on stage
| # Specify the fields to identify the record | ||
| # For example, if 'id' is the unique field: | ||
| id=row.get("id"), | ||
| ) |
There was a problem hiding this comment.
might get weird specifying id like this, but we can try it out and see how it goes
|
This PR includes changes to |
Purpose/Motivation
Swapping this to be update_or_create in the event we update CSVs locally and want to use hot-refresh to get those changes to persist.
Also as part of this change we're removing the django commands from being in "ready" because they would run on every "refresh" of the app rather than on startup directly. By putting it in the dev.sh file we're able to add the seeds for just startup when the API container is ran on its own.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.