Improve aggregate test results function #813
Conversation
this commit also adds the LastDuration field to the TestResult GQL model. The reason we're using latest_run and not the updated_at field of the object is because in the future we want to parse the timestamp from the JUnit XML file so latest_run will be tied to that and not the time at which we process the test results.
|
This PR includes changes to |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #813 +/- ##
================================================
+ Coverage 96.23000 96.24000 +0.01000
================================================
Files 812 812
Lines 18567 18596 +29
================================================
+ Hits 17868 17897 +29
Misses 699 699
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -893,14 +892,15 @@ def test_test_results_no_tests(self) -> None: | |||
| def test_branch_filter_on_test_results(self) -> None: | |||
There was a problem hiding this comment.
am I missing something or are there no assertions on this test and the next two?
There was a problem hiding this comment.
i think the github file viewer is just not showing them, they are there
There was a problem hiding this comment.
oh weird, yeah I see them now
requirements.in
Outdated
| @@ -45,7 +45,7 @@ pytz | |||
| redis | |||
| regex | |||
| requests | |||
| sentry-sdk>=2.13.0 | |||
| sentry-sdk>=1.40.0 | |||
| class Array(Aggregate): | ||
| function = "array" | ||
|
|
||
|
|
||
| def aggregate_test_results( |
There was a problem hiding this comment.
Reminder to update the doc for this fn
utils/test_results.py
Outdated
| When(outcome__in=["failure", "error"], then=Value(1.0)), | ||
| totals = DailyTestRollup.objects.filter(repoid=repoid, date__gt=time_ago) | ||
|
|
||
| print([(t.pass_count, t.fail_count) for t in totals], branch) |
utils/test_results.py
Outdated
| ) | ||
|
|
||
| return failure_rates_queryset | ||
| print(aggregation_of_test_results.query) |
|
|
||
| aggregation_of_test_results = totals.values("test").annotate( | ||
| failure_rate=( | ||
| Cast(Sum(F("fail_count")), output_field=FloatField()) |
There was a problem hiding this comment.
Does the Cast(Sum(F("fail_count"))) get cached when we do this calc twice? I don't have an idea of how we'd simplify, mostly curious if you knew
There was a problem hiding this comment.
i would expect postgres to take care of this in a performant way
This PR does 2 things:
depends on: codecov/worker#699