Update FailedTestsErrorBanner.tsx #3763
Open
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test result report upload / processing errors happen on a commit level, whereas the UI aggregates and displays results on a branch level. Consequently, we may show test results even if the latest commit had errors previously. At which point seeing the banner as written today could invite confusion. I've changed the copy to more accurately describe the behaviour. Feedback welcome
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
ajay-sentry
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test result report upload / processing errors happen on a commit level, whereas the UI aggregates and displays results on a branch level.
Consequently, we may show test results even if the latest commit had errors previously. At which point seeing the banner as written today could invite confusion - see below
I've changed the copy to more accurately describe the behaviour. Feedback welcome
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.