ref: Convert BranchFileEntry to TSX #3777
Conversation
There was a problem hiding this comment.
got rid of mocked network request here because
- The component does not do anything with the data, all it does is trigger the hook call
- it's really annoying requiring us to dig into the query client as a result of not using the data
The response is not relevant to the component at all, testing it here is unnecessary and annoying /rant lol
Bundle ReportChanges will increase total bundle size by 33 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: gazebo-staging-esmAssets Changed:
Files in
Files in
Files in
view changes for bundle: gazebo-staging-systemAssets Changed:
Files in
Files in
Files in
|
Bundle ReportChanges will increase total bundle size by 33 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: gazebo-production-systemAssets Changed:
Files in
Files in
Files in
view changes for bundle: gazebo-production-esmAssets Changed:
Files in
Files in
Files in
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3777 +/- ##
=======================================
Coverage 98.72% 98.72%
=======================================
Files 824 824
Lines 14786 14798 +12
Branches 4242 4249 +7
=======================================
+ Hits 14597 14609 +12
Misses 182 182
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
| components: string[] | ||
| } | ||
|
|
||
| function useTypeSafeFilters(): Filters { |
There was a problem hiding this comment.
will probably pull this out to another file in my next PR converting BranchDirEntry. fine here until then :)
spalmurray-codecov
force-pushed
the
spalmurray/BranchFileEntry-ts
branch
from
f554450 to
5eeaa05
Compare
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3777 +/- ##
=======================================
Coverage 98.72% 98.72%
=======================================
Files 824 824
Lines 14786 14798 +12
Branches 4242 4257 +15
=======================================
+ Hits 14597 14609 +12
Misses 182 182
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3777 +/- ##
=======================================
Coverage 98.72% 98.72%
=======================================
Files 824 824
Lines 14786 14798 +12
Branches 4250 4249 -1
=======================================
+ Hits 14597 14609 +12
Misses 182 182
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3777 +/- ##
=======================================
Coverage 98.72% 98.72%
=======================================
Files 824 824
Lines 14786 14798 +12
Branches 4250 4257 +7
=======================================
+ Hits 14597 14609 +12
Misses 182 182
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Converts BranchFileEntry to TSX and also makes path in PathContents non-nullable following my API change to the GQL schema.
Part of codecov/engineering-team#2747