Add metric for uploads per scheduled tasks

[Swatinem]

The Upload task schedules multiple UploadProcessor tasks and another UploadFinisher.

This batching is rather accidental because of locking rather than intentional. It might be good to know how uploads are being grouped into a single processor/finisher chain.

Also includes a bunch of cleanups and driveby typing fixes.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.14%. Comparing base (80952af) to head (d5ee646).
Report is 10 commits behind head on main.

Changes have been made to critical files, which contain lines commonly executed in production. Learn more

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #718      +/-   ##
==========================================
+ Coverage   98.12%   98.14%   +0.01%     
==========================================
  Files         475      475              
  Lines       38089    38091       +2     
==========================================
+ Hits        37374    37383       +9     
+ Misses        715      708       -7     

Flag	Coverage Δ
integration	98.09% <100.00%> (+0.01%)	⬆️
latest-uploader-overall	98.09% <100.00%> (+0.01%)	⬆️
unit	98.09% <100.00%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
NonTestCode	96.12% <100.00%> (+0.04%)	⬆️
OutsideTasks	98.12% <100.00%> (+0.02%)	⬆️

Files with missing lines	Coverage Δ
services/bundle_analysis/report.py	100.00% <100.00%> (ø)
services/report/__init__.py Critical	97.00% <100.00%> (ø)
services/report/report_processor.py	95.49% <100.00%> (ø)
services/test_results.py	93.71% <100.00%> (+3.61%)	⬆️
tasks/upload.py Critical	97.70% <100.00%> (+0.02%)	⬆️

This change has been scanned for critical changes. Learn more

[codecov-notifications]

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main     #718      +/-   ##
==========================================
+ Coverage   98.07%   98.09%   +0.01%     
==========================================
  Files         434      434              
  Lines       36734    36736       +2     
==========================================
+ Hits        36027    36036       +9     
+ Misses        707      700       -7     

Flag	Coverage Δ
integration	98.09% <100.00%> (+0.01%)	⬆️
latest-uploader-overall	98.09% <100.00%> (+0.01%)	⬆️
unit	98.09% <100.00%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
NonTestCode	96.02% <100.00%> (+0.04%)	⬆️
OutsideTasks	98.12% <100.00%> (+0.02%)	⬆️

Files	Coverage Δ
services/bundle_analysis/report.py	100.00% <100.00%> (ø)
services/report/__init__.py	96.78% <100.00%> (ø)
services/report/report_processor.py	95.49% <100.00%> (ø)
services/test_results.py	93.71% <100.00%> (+3.61%)	⬆️
tasks/upload.py	96.36% <100.00%> (+0.03%)	⬆️

[codecov-qa]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.09%. Comparing base (80952af) to head (d5ee646).
Report is 10 commits behind head on main.

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main     #718      +/-   ##
==========================================
+ Coverage   98.07%   98.09%   +0.01%     
==========================================
  Files         434      434              
  Lines       36734    36736       +2     
==========================================
+ Hits        36027    36036       +9     
+ Misses        707      700       -7     

Flag	Coverage Δ
integration	98.09% <100.00%> (+0.01%)	⬆️
latest-uploader-overall	98.09% <100.00%> (+0.01%)	⬆️
unit	98.09% <100.00%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
NonTestCode	96.02% <100.00%> (+0.04%)	⬆️
OutsideTasks	98.12% <100.00%> (+0.02%)	⬆️

Files with missing lines	Coverage Δ
services/bundle_analysis/report.py	100.00% <100.00%> (ø)
services/report/__init__.py	96.78% <100.00%> (ø)
services/report/report_processor.py	95.49% <100.00%> (ø)
services/test_results.py	93.71% <100.00%> (+3.61%)	⬆️
tasks/upload.py	96.36% <100.00%> (+0.03%)	⬆️

[codecov-public-qa]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.09%. Comparing base (80952af) to head (d5ee646).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main     #718      +/-   ##
==========================================
+ Coverage   98.07%   98.09%   +0.01%     
==========================================
  Files         434      434              
  Lines       36734    36736       +2     
==========================================
+ Hits        36027    36036       +9     
+ Misses        707      700       -7     

Flag	Coverage Δ
integration	98.09% <100.00%> (+0.01%)	⬆️
latest-uploader-overall	98.09% <100.00%> (+0.01%)	⬆️
unit	98.09% <100.00%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
NonTestCode	96.02% <100.00%> (+0.04%)	⬆️
OutsideTasks	98.12% <100.00%> (+0.02%)	⬆️

Files	Coverage Δ
services/bundle_analysis/report.py	100.00% <100.00%> (ø)
services/report/__init__.py	96.78% <100.00%> (ø)
services/report/report_processor.py	95.49% <100.00%> (ø)
services/test_results.py	93.71% <100.00%> (+3.61%)	⬆️
tasks/upload.py	96.36% <100.00%> (+0.03%)	⬆️

[sentry-io]

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

• ‼️ AttributeError: 'list' object has no attribute 'split' app.tasks.upload.Upload View Issue

_{Did you find this useful? React with a 👍 or 👎}