Skip to content

feat(language-dropdown): enhance button layout and logo display #3058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(language-dropdown): enhance button layout and logo display #3058

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ca1ad1
feat(language-dropdown): enhance button layout and logo display
rohitpaulk Aug 27, 2025
1ac0833
fix: increase icon and image size in language dropdown
rohitpaulk Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions app/components/language-dropdown-link.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,12 @@
</div>
<div>
{{#if @isSelected}}
{{svg-jar "check-circle" class="w-4 fill-current text-teal-500"}}
{{svg-jar "check-circle" class="w-5 fill-current text-teal-500"}}
{{else if (and @isRequested (not @isSelected))}}
{{svg-jar "exclamation" class="w-4 fill-current text-yellow-500"}}
{{svg-jar "exclamation" class="w-5 fill-current text-yellow-500"}}
{{else}}
<img src={{@language.grayLogoUrl}} alt={{@language.name}} class="w-4 h-4 block group-hover:hidden" />
<img src={{@language.tealLogoUrl}} alt={{@language.name}} class="w-4 h-4 hidden group-hover:block" />
<img src={{@language.grayLogoUrl}} alt={{@language.name}} class="w-5 h-5 opacity-50 block group-hover:hidden" />
<img src={{@language.tealLogoUrl}} alt={{@language.name}} class="w-5 h-5 hidden group-hover:block" />
{{/if}}
</div>
</div>
13 changes: 10 additions & 3 deletions app/components/language-dropdown.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,19 @@
<dd.Trigger>
<button
type="button"
class="inline-flex justify-center w-full rounded-md border border-gray-300 dark:border-white/10
class="group inline-flex justify-center items-center w-full gap-x-1 rounded-md border border-gray-300 dark:border-white/10
{{if dd.isOpen 'bg-gray-50 dark:bg-gray-800' 'bg-white dark:bg-gray-900'}}
shadow-xs px-4 py-2 text-sm font-medium text-gray-800 dark:text-gray-200 hover:bg-gray-50 dark:hover:bg-gray-800 focus:outline-hidden"
shadow-xs py-2
{{if @selectedLanguage 'pl-2 pr-3' 'px-3'}}
text-sm font-medium text-gray-800 dark:text-gray-200 hover:bg-gray-50 dark:hover:bg-gray-800 focus:outline-hidden"
data-test-language-dropdown-trigger
>
<span class="mr-1" data-test-current-language-name>
{{#if @selectedLanguage}}
<img src={{@selectedLanguage.grayLogoUrl}} alt={{@selectedLanguage.name}} class="w-6 h-6 block group-hover:hidden" />
<img src={{@selectedLanguage.tealLogoUrl}} alt={{@selectedLanguage.name}} class="w-6 h-6 hidden group-hover:block" />
{{/if}}
Copy link

@cursor cursor bot Aug 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Inconsistent Language Selection UI

The language dropdown can display a specific language logo alongside "All Languages" text. This occurs because the logo's display condition only checks for @selectedLanguage's presence, while the text condition uses this.isAllLanguagesOptionSelected, creating a confusing UI when "All Languages" is active but @selectedLanguage still holds a value.

Fix in Cursor Fix in Web


<span data-test-current-language-name>
{{#if this.isAllLanguagesOptionSelected}}
All Languages
{{else}}
Expand Down