-
Notifications
You must be signed in to change notification settings - Fork 26
Remove unused service declarations from components #3086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Remove unused service declarations from components #3086
Conversation
This commit removes unused service injections from various components. This cleans up the codebase and improves maintainability. Co-authored-by: rohitpaulk <[email protected]>
|
Cursor Agent can help with this pull request. Just |
Test Results 1 files ±0 1 suites ±0 8m 38s ⏱️ - 4m 57s For more details on these errors, see this check. Results for commit bb412f3. ± Comparison against base commit 783e97f. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Bundle ReportChanges will decrease total bundle size by 8.65kB (-0.02%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: client-array-pushAssets Changed:
|
This commit injects various services like AuthenticatorService, DarkModeService, and CoursePageStateService into multiple components to enable new functionalities and improve existing ones. Co-authored-by: rohitpaulk <[email protected]>
|
@cursor resolve conflicts |
|
I refactored several components by removing unused service injections to improve code cleanliness and moved the admin panel link to the user account dropdown for better organization and accessibility for administrators.
Learn more about Cursor Agents |
|
@cursor resolve conflicts |
1 similar comment
|
@cursor resolve conflicts |
|
I refactored several components to inject necessary services, primarily
Learn more about Cursor Agents |
Checklist:
[percy]in the message to trigger)This PR removes unused
@servicedeclarations and their corresponding import statements from 54 component files.The goal is to clean up the codebase by eliminating dead code and unnecessary dependencies, improving readability and maintainability.
Slack Thread