-
Notifications
You must be signed in to change notification settings - Fork 28
feat(roadmap): always show RoadmapInfoAlert on all screen sizes #3101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the "hidden md:block" classes from RoadmapInfoAlert components to ensure the informational alerts about challenges and extensions are visible on all screen sizes. Also, update RoadmapInfoAlert to forward HTML attributes to the underlying Alert component for better flexibility. These changes improve user awareness of roadmap concepts regardless of device or viewport.
❌ 1 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Bundle ReportChanges will decrease total bundle size by 235.88kB (-0.61%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: client-array-pushAssets Changed:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the "hidden md:block" classes from RoadmapInfoAlert components
to ensure the informational alerts about challenges and extensions are
visible on all screen sizes. Also, update RoadmapInfoAlert to forward
HTML attributes to the underlying Alert component for better flexibility.
These changes improve user awareness of roadmap concepts regardless of
device or viewport.
This is part 1 of 2 in a stack made with GitButler: