Skip to content

Conversation

@rohitpaulk
Copy link
Member

@rohitpaulk rohitpaulk commented Nov 23, 2025

Always enable dark mode by overriding isEnabled to true in the
dark-mode service to simplify theming during development.
Add three layered, animated blurred gradient backgrounds to the catalog
page for enhanced visual appeal. The gradients use overlapping colored
circles with spin animations and blur effects for a dynamic look.


Note

Always enable dark mode and add animated blurred gradient backgrounds across key pages; refine course/track card dark styles and layout.

  • Styling/Theming
    • Force-enable dark mode by returning true in services/dark-mode.isEnabled.
    • Add animated, blurred gradient background layers to templates/catalog.hbs, templates/course-overview.hbs, and templates/track.hbs.
  • Components
    • components/course-card/index.hbs:
      • Refactor structure to wrap content in a flex column, adjust lock-state opacity/hover, and tweak dark background classes.
      • Preserve logo, text, description, and footer logic; minor class/opacity updates for skeletons and badges.
    • components/tracks-page/track-card/index.hbs:
      • Soften dark background with /70 opacity.
  • Pages
    • templates/track.hbs: switch section background to dark:bg-gray-950 and adjust dark border colors.

Written by Cursor Bugbot for commit d494afe. This will update automatically on new commits. Configure here.

@rohitpaulk rohitpaulk force-pushed the force-enable-dark-mode-gradients branch from 44edd53 to ba0414e Compare November 23, 2025 03:10
@github-actions
Copy link

github-actions bot commented Nov 23, 2025

Test Results

  1 files  ±0    1 suites  ±0   10m 36s ⏱️ + 1m 13s
678 tests ±0  626 ✅  - 1  51 💤 ±0  0 ❌ ±0  1 🔥 +1 
678 runs  ±0  625 ✅  - 2  51 💤 ±0  1 ❌ +1  1 🔥 +1 

For more details on these errors, see this check.

Results for commit d494afe. ± Comparison against base commit cbc9038.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Nov 23, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
627 1 626 51
View the full list of 1 ❄️ flaky test(s)
Chrome 142.0::Acceptance | demo page | dark-mode-toggle: it adds a '.dark' class to application container when Dark mode is active

Flake rate in main: 18.42% (Passed 31 times, Failed 7 times)

Stack Traces | 0.171s run time
class .dark is absent by default

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

get isEnabled(): boolean {
return this.currentRouteSupportsDarkMode && (this.#currentRouteRequiresDarkMode || this.#isEnabledViaPreferences || this.isEnabledTemporarily);
return true;
// return this.currentRouteSupportsDarkMode && (this.#currentRouteRequiresDarkMode || this.#isEnabledViaPreferences || this.isEnabledTemporarily);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Dark mode forced on light-only routes

The isEnabled getter now hardcodes true, forcing dark mode on all routes including those that only support light mode. Routes with RouteColorScheme.Light (the default) will display dark mode styling even though they may lack proper dark mode support. The commented-out original logic suggests this is temporary development code that was accidentally committed.

Fix in Cursor Fix in Web

Always enable dark mode by overriding isEnabled to true in the
dark-mode service to simplify theming during development.
Add three layered, animated blurred gradient backgrounds to the catalog
page for enhanced visual appeal. The gradients use overlapping colored
circles with spin animations and blur effects for a dynamic look.
Introduce fixed blurred gradient overlays to the course overview and 
track pages to enhance visual appeal and maintain design consistency. 
Remove the previously commented out gradient from the catalog page as it
is no longer used.
Also update the track page’s dark mode background and border colors to
darker shades for improved contrast and visual coherence with the new
gradients.
Refactor the course card component to enhance layout structure by moving
the lock icon opacity styles to a child wrapper. This improves visual
consistency when hovering. Update skeleton states for logo and text to
match new layout. Remove redundant elements and streamline the flexbox
setup to better support responsive design and interactions.
@rohitpaulk rohitpaulk force-pushed the force-enable-dark-mode-gradients branch from 92372a7 to b69ffac Compare November 23, 2025 04:31
Update course-card to apply distinct dark background colors based
on the locked state. Adjust opacity of card content when the lock
icon is shown to visually indicate restricted access. These changes
improve the user experience by clearly differentiating locked and
unlocked courses at a glance.
Add the 'grow' class to the card container div so the course card 
content properly expands within its parent. This improves layout 
consistency and ensures that opacity and hover effects work as intended.
Update the background hover color for locked course cards in dark
mode to improve visual feedback and distinguish locked state more
clearly. This change enhances user experience by providing a subtle
hover highlight when the lock icon is shown.
Update the background color of track cards in dark mode to use a
semi-transparent shade, enhancing visual consistency and readability.
This change adjusts the dark mode bg color from solid to bg-gray-925/70.
@codecov
Copy link

codecov bot commented Nov 23, 2025

Bundle Report

Changes will increase total bundle size by 5.72kB (0.01%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
client-array-push 38.78MB 5.72kB (0.01%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/chunk.*.js 5.0kB 3.33MB 0.15%
assets/chunk.*.js 82 bytes 40.93kB 0.2%
assets/chunk.*.css 643 bytes 256.69kB 0.25%

Files in assets/chunk.*.js:

  • ./templates/course-overview.hbs → Total Size: 7.55kB

  • ./services/dark-mode.ts → Total Size: 6.65kB

Files in assets/chunk.*.css:

  • ./templates/course-overview.hbs → Total Size: 7.55kB

  • ./services/dark-mode.ts → Total Size: 6.65kB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants