feat(layout): add noisy overlay controlled by layout service #3339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 1 files ±0 1 suites ±0 9m 48s ⏱️ +30s For more details on these errors, see this check. Results for commit 735a94f. ± Comparison against base commit 750f912. ♻️ This comment has been updated with latest results. |
❌ 1 Tests Failed:
View the full list of 1 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
Bundle ReportChanges will decrease total bundle size by 1.42kB (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: client-array-pushAssets Changed:
Files in
|
rohitpaulk
force-pushed
the
feat-add-noisy-overlay
branch
from
794987c to
ac592de
Compare
Introduce a conditional noisy overlay div in application template that renders when `shouldShowNoisyOverlay` is true. Add a corresponding getter in the layout service, currently mirroring `shouldShowHeader`. This sets up infrastructure for future UI enhancements requiring an overlay effect.
rohitpaulk
force-pushed
the
feat-add-noisy-overlay
branch
from
ac592de to
6473e52
Compare
Increase the background opacity from 0.035 to 0.04 to improve the visibility of the background pattern. This subtle change enhances the overall user interface without affecting interaction, as pointer events remain disabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a conditional noisy overlay div in application template that
renders when
shouldShowNoisyOverlayis true. Add a corresponding getterin the layout service, currently mirroring
shouldShowHeader. This setsup infrastructure for future UI enhancements requiring an overlay effect.
Note
Adds a conditional noisy overlay in the application template controlled by a new layout service getter, sets container to relative, and slightly increases overlay opacity.
app/templates/application.hbsusing{{#if this.layout.shouldShowNoisyOverlay}}that renders a full-viewportdivwithnoisy-overlay.#application-containerrelativeto position the overlay.LayoutService#get shouldShowNoisyOverlaymirroringshouldShowHeader.noisy-overlayopacity from0.035to0.04inapp/styles/app.css.Written by Cursor Bugbot for commit 735a94f. This will update automatically on new commits. Configure here.