lsp worktree init

[Saga4]

PR Type

Enhancement

---

Description

• Add LSP commands for git worktree management

• Introduce WorktreeParams dataclass for requests

• Implement createWorktree to setup worktrees

• Implement removeWorktree to cleanup worktrees

---

Diagram Walkthrough

flowchart LR
  A["VSCode LSP request"] -- "createWorktree" --> B["create_worktree handler"]
  B --> C["create_worktree_root_dir"]
  B --> D["create_git_worktrees"]
  D --> E["register worktrees"]
  E --> F["return success response"]
  A -- "removeWorktree" --> G["remove_worktree handler"]
  G --> H["remove_git_worktrees"]
  H --> I["cleanup registry"]
  I --> J["return success response"]

Loading

File Walkthrough

	Relevant files
Enhancement	beta.py Add worktree management functions                                                codeflash/lsp/beta.py Imported git utility functions: create_git_worktrees, create_worktree_root_dir, remove_git_worktrees Added WorktreeParams dataclass for LSP params Implemented createWorktree LSP feature for creating worktrees Implemented removeWorktree LSP feature for cleanup +114/-0

---

[github-actions]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Input Validation The gitRoot, functionName, and candidateId parameters are used directly for filesystem and registry operations without sanitization. Consider validating and sanitizing inputs to avoid path traversal or injection risks. try: module_root = Path(params.gitRoot) # Create worktree root directory git_root, worktree_root_dir = create_worktree_root_dir(module_root) Race Condition The shared server.worktree_registry is modified without synchronization. Concurrent LSP requests could cause inconsistent state. Consider adding thread-safety or locking mechanisms. if not hasattr(server, "worktree_registry"): server.worktree_registry = {} server.worktree_registry[params.candidateId] = { "worktree_root": worktree_root, "worktrees": worktrees, "function_name": params.functionName, } Broad Exception Both handlers catch all exceptions, potentially hiding unexpected errors and making debugging harder. It's better to catch specific exceptions and let others surface. except Exception as e: server.show_message_log(f"Error creating worktree: {e!s}", "Error") return { "functionName": params.functionName, "candidateId": params.candidateId, "status": "error", "message": f"Error creating worktree: {e!s}", }

[github-actions]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
Possible issue	Validate gitRoot directory Validate that params.gitRoot points to an existing directory before proceeding to avoid confusing failures when the path is invalid. If the check fails, log an error and return an appropriate error response. codeflash/lsp/beta.py [313] module_root = Path(params.gitRoot) +if not module_root.is_dir(): + server.show_message_log("Invalid gitRoot path", "Error") + return { + "functionName": params.functionName, + "candidateId": params.candidateId, + "status": "error", + "message": "Invalid gitRoot path", + } Suggestion importance[1-10]: 6 __ Why: Adding a directory existence check on module_root prevents proceeding with an invalid gitRoot and avoids downstream errors.	Low
General	Use pop to remove entry Replace the del statement with pop to remove the entry and safely handle missing keys without raising a KeyError. codeflash/lsp/beta.py [394] -del server.worktree_registry[params.candidateId] +server.worktree_registry.pop(params.candidateId, None) Suggestion importance[1-10]: 5 __ Why: Replacing del with pop safely handles missing keys without raising a KeyError and improves error resilience.	Low
	Initialize registry atomically Use getattr to initialize worktree_registry with a default empty dict in one line, preserving any existing entries and avoiding repeated attribute checks. codeflash/lsp/beta.py [340-341] -if not hasattr(server, "worktree_registry"): - server.worktree_registry = {} +server.worktree_registry = getattr(server, "worktree_registry", {}) Suggestion importance[1-10]: 4 __ Why: The getattr approach reduces boilerplate for initializing worktree_registry, but it’s a minor style improvement.	Low

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

---

saga4 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[mohammedahmed18]

the function_optimizer here is pointing to the same path (current_function.file_path)
not the worktree path.

[mohammedahmed18]

why do we have multiple worktrees here ?