⚡️ Speed up function _is_user_proxy_admin by 22%

[codeflash-ai]

📄 22% (0.22x) speedup for _is_user_proxy_admin in litellm/proxy/auth/auth_checks.py

⏱️ Runtime : 61.1 microseconds → 50.0 microseconds (best of 157 runs)

📝 Explanation and details

The optimization eliminates redundant code and reduces the number of conditional checks by combining early exit conditions and removing duplicate logic blocks.

Key changes:

1. Combined null checks: The original code checked user_obj is None and user_obj.user_role is not None separately in multiple places. The optimized version combines these into a single early exit: if user_obj is None or user_obj.user_role is None:

2. Removed duplicate conditional blocks: The original code had two identical if statements checking the same condition (user_obj.user_role == LitellmUserRoles.PROXY_ADMIN.value), which was clearly a copy-paste error.

3. Direct return statement: Instead of multiple conditional branches, the optimized version uses a single direct comparison: return user_obj.user_role == LitellmUserRoles.PROXY_ADMIN.value

Why this is faster:

• Fewer attribute accesses: The original code accessed user_obj.user_role up to 4 times per call, while the optimized version accesses it at most 2 times
• Reduced branching: From 3+ conditional branches down to 2, reducing CPU branch prediction overhead
• Earlier exit: Null checks happen first, avoiding unnecessary enum comparison for invalid inputs

Performance impact in context:
Based on the function references, this function is called in authentication hot paths:

• _is_api_route_allowed() calls it for every API request to check admin privileges
• _return_user_api_key_auth_obj() calls it during user authentication flows

The 22% speedup is most beneficial for non-admin users with null/invalid roles (27.5% faster as shown in tests), which are likely the majority of cases, making this optimization particularly valuable for high-traffic authentication scenarios.

✅ Correctness verification report:

Test	Status
⚙️ Existing Unit Tests	🔘 None Found
🌀 Generated Regression Tests	✅ 34 Passed
⏪ Replay Tests	🔘 None Found
🔎 Concolic Coverage Tests	🔘 None Found
📊 Tests Coverage	85.7%

🌀 Generated Regression Tests and Runtime

from enum import Enum
from typing import Optional

# imports
import pytest
from litellm.proxy.auth.auth_checks import _is_user_proxy_admin

# --- Function and dependencies to test ---

# Enum for user roles
class LitellmUserRoles(Enum):
    USER = "USER"
    PROXY_ADMIN = "PROXY_ADMIN"
    SUPER_ADMIN = "SUPER_ADMIN"
    GUEST = "GUEST"
    # Add more roles as needed

# Simulated user table object
class LiteLLM_UserTable:
    def __init__(self, user_role: Optional[str] = None):
        self.user_role = user_role
from litellm.proxy.auth.auth_checks import _is_user_proxy_admin

# --- Unit Tests ---

# 1. Basic Test Cases

def test_none_user_obj_returns_false():
    # Test with None input
    codeflash_output = _is_user_proxy_admin(None) # 462ns -> 512ns (9.77% slower)

def test_user_role_proxy_admin_returns_true():
    # Test with user_role exactly "PROXY_ADMIN"
    user = LiteLLM_UserTable(user_role=LitellmUserRoles.PROXY_ADMIN.value)
    codeflash_output = _is_user_proxy_admin(user) # 1.89μs -> 1.59μs (19.4% faster)

def test_user_role_user_returns_false():
    # Test with user_role "USER"
    user = LiteLLM_UserTable(user_role=LitellmUserRoles.USER.value)
    codeflash_output = _is_user_proxy_admin(user) # 1.44μs -> 1.17μs (23.5% faster)

def test_user_role_super_admin_returns_false():
    # Test with user_role "SUPER_ADMIN"
    user = LiteLLM_UserTable(user_role=LitellmUserRoles.SUPER_ADMIN.value)
    codeflash_output = _is_user_proxy_admin(user) # 1.52μs -> 1.28μs (19.1% faster)

def test_user_role_guest_returns_false():
    # Test with user_role "GUEST"
    user = LiteLLM_UserTable(user_role=LitellmUserRoles.GUEST.value)
    codeflash_output = _is_user_proxy_admin(user) # 1.51μs -> 1.23μs (23.3% faster)

# 2. Edge Test Cases

def test_user_role_none_returns_false():
    # Test with user_role = None
    user = LiteLLM_UserTable(user_role=None)
    codeflash_output = _is_user_proxy_admin(user) # 608ns -> 477ns (27.5% faster)

def test_user_role_empty_string_returns_false():
    # Test with user_role = ""
    user = LiteLLM_UserTable(user_role="")
    codeflash_output = _is_user_proxy_admin(user) # 2.11μs -> 1.69μs (24.9% faster)

def test_user_role_lowercase_proxy_admin_returns_false():
    # Test with user_role = "proxy_admin" (lowercase)
    user = LiteLLM_UserTable(user_role="proxy_admin")
    codeflash_output = _is_user_proxy_admin(user) # 1.69μs -> 1.57μs (7.30% faster)

def test_user_role_proxy_admin_with_spaces_returns_false():
    # Test with user_role = " PROXY_ADMIN "
    user = LiteLLM_UserTable(user_role=" PROXY_ADMIN ")
    codeflash_output = _is_user_proxy_admin(user) # 2.00μs -> 1.40μs (43.1% faster)

def test_user_role_proxy_admin_with_typo_returns_false():
    # Test with user_role = "PROXY-ADMIN" (typo)
    user = LiteLLM_UserTable(user_role="PROXY-ADMIN")
    codeflash_output = _is_user_proxy_admin(user) # 1.95μs -> 1.50μs (29.7% faster)

def test_user_role_integer_returns_false():
    # Test with user_role = integer (invalid type)
    user = LiteLLM_UserTable(user_role=12345)
    codeflash_output = _is_user_proxy_admin(user) # 2.00μs -> 1.51μs (32.0% faster)

def test_user_role_list_returns_false():
    # Test with user_role = list (invalid type)
    user = LiteLLM_UserTable(user_role=["PROXY_ADMIN"])
    codeflash_output = _is_user_proxy_admin(user) # 1.98μs -> 1.56μs (26.4% faster)

def test_user_role_dict_returns_false():
    # Test with user_role = dict (invalid type)
    user = LiteLLM_UserTable(user_role={"role": "PROXY_ADMIN"})
    codeflash_output = _is_user_proxy_admin(user) # 2.13μs -> 1.70μs (25.7% faster)

def test_user_obj_missing_user_role_attribute():
    # Test with object missing user_role attribute
    class NoRole:
        pass
    user = NoRole()
    # Should raise AttributeError
    with pytest.raises(AttributeError):
        _is_user_proxy_admin(user) # 1.47μs -> 1.44μs (1.87% faster)

def test_user_obj_user_role_is_enum_returns_false():
    # Test with user_role as Enum (not .value)
    user = LiteLLM_UserTable(user_role=LitellmUserRoles.PROXY_ADMIN)
    codeflash_output = _is_user_proxy_admin(user) # 2.32μs -> 1.77μs (31.3% faster)

def test_user_obj_user_role_is_bytes_returns_false():
    # Test with user_role as bytes
    user = LiteLLM_UserTable(user_role=b"PROXY_ADMIN")
    codeflash_output = _is_user_proxy_admin(user) # 1.96μs -> 1.64μs (19.7% faster)

def test_user_obj_user_role_is_boolean_returns_false():
    # Test with user_role as boolean
    user = LiteLLM_UserTable(user_role=True)
    codeflash_output = _is_user_proxy_admin(user) # 2.01μs -> 1.60μs (26.0% faster)

def test_user_obj_user_role_is_float_returns_false():
    # Test with user_role as float
    user = LiteLLM_UserTable(user_role=1.0)
    codeflash_output = _is_user_proxy_admin(user) # 2.09μs -> 1.54μs (35.5% faster)

# 3. Large Scale Test Cases

import pytest
from litellm.proxy.auth.auth_checks import _is_user_proxy_admin


# function to test
# Simulated enums and user table for self-contained testing
class LitellmUserRoles:
    # Simulate an enum with .value attributes
    PROXY_ADMIN = type("Enum", (), {"value": "proxy_admin"})
    USER = type("Enum", (), {"value": "user"})
    SUPER_ADMIN = type("Enum", (), {"value": "super_admin"})
    NONE = type("Enum", (), {"value": None})

class LiteLLM_UserTable:
    def __init__(self, user_role=None):
        self.user_role = user_role
from litellm.proxy.auth.auth_checks import _is_user_proxy_admin

# unit tests

# 1. Basic Test Cases

def test_none_user_obj_returns_false():
    # Test when user_obj is None
    codeflash_output = _is_user_proxy_admin(None) # 492ns -> 474ns (3.80% faster)

def test_user_role_is_proxy_admin_returns_true():
    # Test when user_obj.user_role is exactly PROXY_ADMIN
    user = LiteLLM_UserTable(user_role="proxy_admin")
    codeflash_output = _is_user_proxy_admin(user) # 2.42μs -> 2.78μs (13.0% slower)

def test_user_role_is_not_proxy_admin_returns_false():
    # Test when user_obj.user_role is USER
    user = LiteLLM_UserTable(user_role="user")
    codeflash_output = _is_user_proxy_admin(user) # 2.06μs -> 1.58μs (30.4% faster)

def test_user_role_is_super_admin_returns_false():
    # Test when user_obj.user_role is SUPER_ADMIN
    user = LiteLLM_UserTable(user_role="super_admin")
    codeflash_output = _is_user_proxy_admin(user) # 2.01μs -> 1.57μs (28.4% faster)

def test_user_role_is_none_returns_false():
    # Test when user_obj.user_role is None
    user = LiteLLM_UserTable(user_role=None)
    codeflash_output = _is_user_proxy_admin(user) # 589ns -> 508ns (15.9% faster)

# 2. Edge Test Cases

def test_user_role_is_empty_string_returns_false():
    # Test when user_obj.user_role is empty string
    user = LiteLLM_UserTable(user_role="")
    codeflash_output = _is_user_proxy_admin(user) # 2.30μs -> 1.70μs (35.2% faster)

def test_user_role_is_integer_returns_false():
    # Test when user_obj.user_role is an integer
    user = LiteLLM_UserTable(user_role=123)
    codeflash_output = _is_user_proxy_admin(user) # 2.07μs -> 1.64μs (26.0% faster)

def test_user_role_is_boolean_returns_false():
    # Test when user_obj.user_role is a boolean
    user = LiteLLM_UserTable(user_role=True)
    codeflash_output = _is_user_proxy_admin(user) # 2.03μs -> 1.56μs (29.8% faster)

def test_user_role_is_list_returns_false():
    # Test when user_obj.user_role is a list
    user = LiteLLM_UserTable(user_role=["proxy_admin"])
    codeflash_output = _is_user_proxy_admin(user) # 2.02μs -> 1.62μs (24.6% faster)

def test_user_role_is_dict_returns_false():
    # Test when user_obj.user_role is a dict
    user = LiteLLM_UserTable(user_role={"role": "proxy_admin"})
    codeflash_output = _is_user_proxy_admin(user) # 2.13μs -> 1.65μs (29.1% faster)

def test_user_role_is_proxy_admin_with_whitespace_returns_false():
    # Test when user_obj.user_role is ' proxy_admin ' (with whitespace)
    user = LiteLLM_UserTable(user_role=" proxy_admin ")
    codeflash_output = _is_user_proxy_admin(user) # 1.94μs -> 1.46μs (33.0% faster)

def test_user_role_is_proxy_admin_uppercase_returns_false():
    # Test when user_obj.user_role is 'PROXY_ADMIN' (uppercase)
    user = LiteLLM_UserTable(user_role="PROXY_ADMIN")
    codeflash_output = _is_user_proxy_admin(user) # 1.92μs -> 1.39μs (38.5% faster)

def test_user_role_is_proxy_admin_mixed_case_returns_false():
    # Test when user_obj.user_role is 'Proxy_Admin' (mixed case)
    user = LiteLLM_UserTable(user_role="Proxy_Admin")
    codeflash_output = _is_user_proxy_admin(user) # 1.87μs -> 1.48μs (26.2% faster)

def test_user_obj_missing_user_role_attribute():
    # Test when user_obj does not have user_role attribute
    class NoRoleUser:
        pass
    user = NoRoleUser()
    # Should raise AttributeError
    with pytest.raises(AttributeError):
        _is_user_proxy_admin(user) # 1.47μs -> 1.43μs (2.72% faster)

def test_user_obj_user_role_is_property_returns_false():
    # Test when user_obj.user_role is a property returning 'proxy_admin'
    class UserWithProperty:
        @property
        def user_role(self):
            return "proxy_admin"
    user = UserWithProperty()
    codeflash_output = _is_user_proxy_admin(user) # 2.24μs -> 2.07μs (7.96% faster)

def test_user_obj_user_role_is_callable_returns_false():
    # Test when user_obj.user_role is a method returning 'proxy_admin'
    class UserWithMethod:
        def user_role(self):
            return "proxy_admin"
    user = UserWithMethod()
    # This should be False, since user_role is a method, not a string
    codeflash_output = _is_user_proxy_admin(user) # 2.35μs -> 1.93μs (21.9% faster)

# 3. Large Scale Test Cases

To edit these changes git checkout codeflash/optimize-_is_user_proxy_admin-mhwu1trb and push.