Skip to content

⚡️ Speed up method TransformsContainer._is_superset by 132% #629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up method TransformsContainer._is_superset by 132% #629

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions marimo/_plugins/ui/_impl/dataframes/transforms/apply.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,11 +143,11 @@ def _is_superset(self, transforms: Transformations) -> bool:
if len(self._transforms) > len(transforms.transforms):
return False

for i, transform in enumerate(self._transforms):
if transform != transforms.transforms[i]:
return False
# Fast path: check if the two lists are identical up to self._transforms
if self._transforms == transforms.transforms[: len(self._transforms)]:
return True

return True
return False

def _get_next_transformations(
self, transforms: Transformations
Expand Down