Skip to content

⚡️ Speed up function make_basic_auth_response by 38% #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

⚡️ Speed up function make_basic_auth_response by 38% #136

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions mlflow/server/auth/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,14 +148,15 @@ def is_unprotected_route(path: str) -> bool:


def make_basic_auth_response() -> Response:
res = make_response(
# Create the Response object directly to avoid extra overhead from make_response
return Response(
"You are not authenticated. Please see "
"https://www.mlflow.org/docs/latest/auth/index.html#authenticating-to-mlflow "
"on how to authenticate."
"on how to authenticate.",
status=401,
headers={"WWW-Authenticate": 'Basic realm="mlflow"'},
mimetype="text/html"
)
res.status_code = 401
res.headers["WWW-Authenticate"] = 'Basic realm="mlflow"'
return res


def make_forbidden_response() -> Response:
Expand Down