Skip to content

⚡️ Speed up function _re_compile_path by 25% #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

⚡️ Speed up function _re_compile_path by 25% #139

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion mlflow/server/auth/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,8 @@
from mlflow.utils.rest_utils import _REST_API_PATH_PREFIX
from mlflow.utils.search_utils import SearchUtils

_ANGLE_BRACKET_PATTERN = re.compile(r"<([^>]+)>")

try:
from flask_wtf.csrf import CSRFProtect
except ImportError as e:
Expand Down Expand Up @@ -450,7 +452,7 @@ def _re_compile_path(path: str) -> re.Pattern:
Convert a path with angle brackets to a regex pattern. For example,
"/api/2.0/experiments/<experiment_id>" becomes "/api/2.0/experiments/([^/]+)".
"""
return re.compile(re.sub(r"<([^>]+)>", r"([^/]+)", path))
return re.compile(_ANGLE_BRACKET_PATTERN.sub(r"([^/]+)", path))


BEFORE_REQUEST_VALIDATORS = {
Expand Down