⚡️ Speed up function lcm
by 27%
#47
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 27% (0.27x) speedup for
lcm
insrc/math/computation.py
⏱️ Runtime :
3.83 milliseconds
→3.01 milliseconds
(best of109
runs)📝 Explanation and details
Here is your optimized code. The main improvement is moving the gcd function outside so it isn't redefined on every call to lcm. This reduces function creation overhead, especially if lcm is called multiple times.
This avoids the inner function allocation, improving both speed and memory, especially for repeated calls.
✅ Correctness verification report:
🌀 Generated Regression Tests and Runtime
To edit these changes
git checkout codeflash/optimize-lcm-mdgvyr4g
and push.