Skip to content

⚡️ Speed up function fillna by 5,211% #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up function fillna by 5,211% #72

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/numpy_pandas/dataframe_operations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,14 +66,17 @@ def pivot_table(

def agg_func(values):
return sum(values) / len(values)

elif aggfunc == "sum":

def agg_func(values):
return sum(values)

elif aggfunc == "count":

def agg_func(values):
return len(values)

else:
raise ValueError(f"Unsupported aggregation function: {aggfunc}")
grouped_data = {}
Expand Down Expand Up @@ -106,9 +109,9 @@ def apply_function(df: pd.DataFrame, column: str, func: Callable) -> List[Any]:

def fillna(df: pd.DataFrame, column: str, value: Any) -> pd.DataFrame:
result = df.copy()
for i in range(len(df)):
if pd.isna(df.iloc[i][column]):
result.iloc[i, df.columns.get_loc(column)] = value
# Replace NA values in the specified column using efficient vectorized operation
mask = result[column].isna()
result.loc[mask, column] = value
return result


Expand Down