Skip to content

⚡️ Speed up function manual_convolution_1d by 710% #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up function manual_convolution_1d by 710% #75

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/numpy_pandas/signal_processing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@ def manual_convolution_1d(signal: np.ndarray, kernel: np.ndarray) -> np.ndarray:
signal_len = len(signal)
kernel_len = len(kernel)
result_len = signal_len - kernel_len + 1
result = np.zeros(result_len)
result = np.empty(result_len)
# Vectorized implementation for better speed and memory efficiency
for i in range(result_len):
for j in range(kernel_len):
result[i] += signal[i + j] * kernel[j]
result[i] = np.dot(signal[i : i + kernel_len], kernel)
return result


Expand Down