Skip to content

fix: update eventbus type to jetstream in values.yaml #612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions charts/gitops-runtime/tests/eventbus_test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,16 +30,16 @@ tests:
- notExists:
path: spec.nats

- it: Should create an EventBus with the correct default name (nats)
- it: Should create an EventBus with the correct default name (jetstream)
template: eventbus/codefresh-eventbus.yaml
values:
- ./values/mandatory-values.yaml
set:
global.runtime.eventBus.type: nats
global.runtime.eventBus.type: jetstream
asserts:
- equal:
path: metadata.name
value: codefresh-eventbus
value: codefresh-eventbus-jetstream

- it: Should create an EventBus with the correct override name (nats)
template: eventbus/codefresh-eventbus.yaml
Expand Down
8 changes: 4 additions & 4 deletions charts/gitops-runtime/tests/global_constraints_test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -119,13 +119,13 @@ tests:
template: event-reporters/workflow-reporter/sensor.yaml
# -- codefresh-eventbus
- equal:
path: spec.nats.native.nodeSelector
path: spec.jetstream.nodeSelector
value:
some-key: some-value
extra-key: extra-value
template: eventbus/codefresh-eventbus.yaml
- equal:
path: spec.nats.native.tolerations
path: spec.jetstream.tolerations
value:
- key: some-key
operator: Equal
Expand Down Expand Up @@ -456,13 +456,13 @@ tests:
template: event-reporters/workflow-reporter/sensor.yaml
# -- codefresh-eventbus
- equal:
path: spec.nats.native.nodeSelector
path: spec.jetstream.nodeSelector
value:
some-key: another-value
foo: bar
template: eventbus/codefresh-eventbus.yaml
- equal:
path: spec.nats.native.tolerations
path: spec.jetstream.tolerations
value:
- key: another-key
operator: Equal
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,9 @@ anchors:
global:
runtime:
eventBus:
nats:
native:
nodeSelector: *nodeSelector
tolerations: *tolerations
jetstream:
nodeSelector: *nodeSelector
tolerations: *tolerations

app-proxy:
nodeSelector: *nodeSelector
Expand Down
2 changes: 1 addition & 1 deletion charts/gitops-runtime/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ global:
enabled: true
# -- Minimum number of available eventbus pods. For eventbus to stay functional the majority of its replicas should always be available.
minAvailable: 2
type: nats # -- Eventbus type. Can be nats or jetstream.
type: jetstream # -- Eventbus type. Can be nats or jetstream.
nats:
native:
metadata:
Expand Down