CG-17310: Disable PR creation Sentry errors #1041
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When trying to create a PR on a branch that already has a PR, a Sentry error is generated and the agent is not shown a good error message.
Changes
GitRepoClient.create_pull
to check if a PR already exists for the branch before attempting to create a new oneCodebase.create_pr
to useget_or_create_pull
instead ofcreate_pull
to handle the case when a PR already existsTesting
Added a new test case
test_codebase_create_pr_existing_pr
that verifies the behavior when trying to create a PR on a branch that already has a PR.Fixes CG-17310
💻 View my work • About Codegen