Skip to content

fix: don't store a serialized exception on error #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 31, 2025

Conversation

michalsn
Copy link
Member

Description
This PR fixes a bug where serialized exceptions could exceed the length of the database field, potentially causing errors or data loss. To prevent this, exceptions will now be stored as simplified text representations, including only essential information such as the message and file location.

Fixes: #187

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@coveralls
Copy link

Pull Request Test Coverage Report for Build 15168420849

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.0%) to 78.252%

Totals Coverage Status
Change from base Build 14830335385: 1.0%
Covered Lines: 367
Relevant Lines: 469

💛 - Coveralls

Copy link
Contributor

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@michalsn michalsn merged commit 8ff0197 into codeigniter4:develop May 31, 2025
27 checks passed
@michalsn
Copy link
Member Author

Thank you @datamweb and @paulbalandan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Potential Data Truncation in Task Logs Leading to Errors with php spark tasks:list
4 participants