[이승환] Sprint5, 6#304
Merged
withyj-codeit merged 12 commits intocodeit-bootcamp-frontend:React-이승환from Jan 31, 2025
Hidden character warning
The head ref may contain hidden characters: "React-\uc774\uc2b9\ud658\ud658-sprint5"
Merged
Conversation
withyj-codeit
approved these changes
Jan 31, 2025
Contributor
withyj-codeit
left a comment
withyj-codeit
left a comment
There was a problem hiding this comment.
스프린트 미션 하느라 수고 많으셨어요~👏🏻
|
|
||
| @media (max-width: 1199px) { | ||
| .body { | ||
| padding: 0 24px 0; |
Contributor
There was a problem hiding this comment.
0 24px 과 결과가 동일해서 확인하면 좋을 것 같아요.
| const [isOpen, setIsOpen] = useState(false); | ||
|
|
||
| const handleToggle = () => { | ||
| setIsOpen((prev) => !prev); |
| function PageNation({ currentPage, totalPages, onPageChange }) { | ||
| // 5개씩 묶은 페이지 버튼 생성 | ||
| const getPageButtons = () => { | ||
| const startPage = Math.floor((currentPage - 1) / 5) * 5 + 1; |
Contributor
There was a problem hiding this comment.
5라는 숫자를 상수로 빼주면 더 좋을 것 같아요.
| @@ -0,0 +1,84 @@ | |||
| import styled from "styled-components"; | |||
| import styles from "./ProductList.module.css"; | |||
Contributor
There was a problem hiding this comment.
styled-components, module css 혼용해서 사용하고 있는데, 학습 목적이 아니라면 하나를 정해서 사용하는 걸 권장드려요.
| ); | ||
| } | ||
|
|
||
| export default Dropdown; |
Contributor
There was a problem hiding this comment.
Dropdown은 만들고 사용하는 곳은 없나요?
| 상품 등록하기 | ||
| </button> | ||
| </Link> | ||
| {/* 드롭다운 */} |
Contributor
There was a problem hiding this comment.
여기 있는 부분을 Dropdown 컴포넌트로 대체하나요?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
요구사항
기본
심화
주요 변경사항
스크린샷
멘토에게