Basic 정태인#76
Merged
kiJu2 merged 6 commits intocodeit-bootcamp-frontend:Basic-정태인from Mar 10, 2025
TAEINJEONG:Basic-정태인
Hidden character warning
The head ref may contain hidden characters: "Basic-\uc815\ud0dc\uc778"
Merged
Conversation
Collaborator
|
스프리트 미션 하시느라 수고 많으셨어요. |
kiJu2
approved these changes
Mar 10, 2025
Comment on lines
+1
to
+12
| * { | ||
| --blue: #3692FF; | ||
| --gray-50: #F9FAFB; | ||
| --gray-100: #F3F4F6; | ||
| --gray-200: #E5E7EB; | ||
| --gray-400: #9CA3AF; | ||
| --gray-500: #6B7280; | ||
| --gray-600: #4B5563; | ||
| --gray-700: #374151; | ||
| --gray-800: #1F2937; | ||
| --gray-900: #111827; | ||
| } No newline at end of file |
Collaborator
There was a problem hiding this comment.
굿굿 ! 컬러 팔레트를 작성하셨군요 !
재사용하기 용이해보이네요 ㅎㅎ. 피드백 반영 좋습니다 ! 👍👍
|
|
||
|
|
||
| /* tablet 사이즈 */ | ||
| @media only screen and (max-width: 1199px) { |
| @media only screen and (max-width: 1199px) { | ||
| .header-nav { | ||
| padding: 10px 24px; | ||
| width: calc(100% - 48px); |
Collaborator
There was a problem hiding this comment.
(제안) 혹시 margin으로 대할 수 있지 않을까요?
Suggested change
| width: calc(100% - 48px); | |
| margin: 0 24px; |
Comment on lines
+13
to
+25
| <meta property="og:type" content="website"> | ||
| <meta property="og:url" content="https://shiny-gnome-34241f.netlify.app/"> | ||
| <meta property="og:title" content="판다마켓"> | ||
| <meta property="og:description" content="일상의 모든 물건을 거래해보세요"> | ||
| <meta property="og:image" content="./assets/images/logo.svg"> | ||
| <meta property="og:image:width" content="1200"> | ||
| <meta property="og:image:height" content="630"> | ||
|
|
||
| <meta name="twitter:card" content="summary_large_image"> | ||
| <meta name="twitter:url" content="https://shiny-gnome-34241f.netlify.app/"> | ||
| <meta name="twitter:title" content="판다마켓"> | ||
| <meta name="twitter:description" content="일상의 모든 물건을 거래해보세요"> | ||
| <meta name="twitter:image" content="./assets/images/logo.svg"> |
Collaborator
There was a problem hiding this comment.
크으 SEO에 잘 신경쓰고 계시군요 !
놓칠 수 있는 부분일 수 있는데 꼼꼼히 잘 작성하셨네요. 훌륭합니다 👍
| <div class="input-container"> | ||
| <label class="text-gray800 label-text">이메일</label> | ||
| <input class="text-gray800 gray100 styled-input" placeholder="이메일을 입력해 주세요"/> | ||
| <input class="text-gray800 gray100 styled-input" placeholder="이메일을 입력해 주세요" type="email"/> |
Collaborator
There was a problem hiding this comment.
굿굿 ~ 타입도 적절히 적용 잘 변경하셨네요 !
다음과 같은 속성도 고려해볼 수 있겠어요:
name:name은<form>을 사용해서 추 후submit을 사용하여 접근할 때 사용될 수 있습니다.required:required는<form>내부에서 서식을 작성하지 않았을 때 브라우저에서 유저에게 피드백을 줄 수 있습니다.
Collaborator
There was a problem hiding this comment.
저번에도 전달드리기는 했으나 한 번 다시 언급드립니다 😊
Collaborator
|
수고하셨습니다 태인님 ! 미션 수행하시느라 정말 수고 많으셨습니다 ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
요구사항
기본
심화
주요 변경사항
스크린샷
렌딩 페이지 tablet 비율 반응형
렌딩 페이지 mobile 비율 반응형
로그인 페이지 mobile 비율 반응형
시연 영상
2025-03-06.8.00.23.mov
카카오톡 공유시
디스코드 공유시
페이스북 공유시
배포 링크
https://spiffy-belekoy-52ef46.netlify.app/
멘토에게