[유기주] sprint8#544
Open
YUKIJOO wants to merge 7 commits intocodeit-bootcamp-frontend:mainfrom
Hidden character warning
The head ref may contain hidden characters: "react-\uc720\uae30\uc8fc-sprintmission8"
Open
Conversation
* reset * fix: 머지 후 브랜치 삭제 github action 수정 * env: workflows 폴더로 이동 * "상품 등록하기 -router 및 css 연결" * "상품등록하기-html" * "상품등록하기-헤더부분" * "상품등록하기 - 내용 상자 생성 및 input설정" * "상품 등록하기 - 전체 index 및 버튼컴포넌트 생성 중" * "sprintmission - 이미지 자료" --------- Co-authored-by: hanseulhee <3021062@gmail.com> Co-authored-by: withyj-codeit <48437814+withyj-codeit@users.noreply.github.com> Co-authored-by: YUKIJOO <koreala1@naver.com>
* reset * fix: 머지 후 브랜치 삭제 github action 수정 * env: workflows 폴더로 이동 * sprintmission7 - 아이템 품목 라우터 하나로 묶기 * "sprintmission5~6" * "sprintmission7"- 상품 상세 페이지 생성 --------- Co-authored-by: hanseulhee <3021062@gmail.com> Co-authored-by: withyj-codeit <48437814+withyj-codeit@users.noreply.github.com> Co-authored-by: YUKIJOO <koreala1@naver.com>
domuk-k
approved these changes
May 26, 2024
Collaborator
There was a problem hiding this comment.
고생하셨습니다
-
js/jsx 파일을 ts로 바꿔주셨는데, TS가 jsx를 제대로 컴파일 하려면 tsx확장자로 지정해줘야합니다. TS에서는 "<" 토큰이 타입을 지정/전달하기 위한 토큰으로 사용되는데(
const a = <string>''), jsx표현으로 "<",">" 토큰이 들어가기떄문에, TS 컴파일러가 jsx를 제대로 인식할 수 있도록 구분해주기 위해서라도 꼭 필요한 구분입니다. -
package.json에 타입체크하는 스크립트를 추가하셔서 활용해보시면 좋겠습니다.
"scripts": {
"tsc": "tsc --noEmit"
}
| "scripts": { | ||
| "start": "react-scripts start", | ||
| "build": "react-scripts build", | ||
| "build": "tsc", |
Collaborator
There was a problem hiding this comment.
수정하신 build 스크립트를 실행하면, (현재 tsconfig.json과 기본동작에 따라) 개별파일을 js로 빌드하게 됩니다. CreactReactApp이 사용하는 도구인 react-scripts 의 build 동작과 비교해보시면 좋겠습니다.
물론 CRA프로젝트를 쉽게, 서비스될 수 있게 빌드하는 방법은 기존코드입니다 (ts 컴파일은 알아서 적용됩니다)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
요구사항
기본
심화
주요 변경사항
스크린샷
멘토에게