[박지민] sprint8#553
Open
JiminN2 wants to merge 11 commits intocodeit-bootcamp-frontend:mainfrom
Hidden character warning
The head ref may contain hidden characters: "React-\ubc15\uc9c0\ubbfc-sprint8"
Open
Conversation
* reset * fix: 머지 후 브랜치 삭제 github action 수정 * env: workflows 폴더로 이동 * first commit --------- Co-authored-by: hanseulhee <3021062@gmail.com> Co-authored-by: withyj-codeit <48437814+withyj-codeit@users.noreply.github.com>
domuk-k
approved these changes
May 26, 2024
Collaborator
domuk-k
left a comment
domuk-k
left a comment
There was a problem hiding this comment.
고생하셨습니다 ts 프로젝트를 새로 만드는 방향을 선택하시고, 새로운 프로젝트에 prettier 도 적용해보셨군요 👍
npm run start스크립트로 개발서버에서 빌드에러, 런타임 에러없이 동작하는지 확인하시면서 진행하시면 좋겠습니다. 간단한 기능이라도 명확히 동작하는지 스스로 확인하시면서 진행하시는 게 효과적입니다.- package.json에 타입체크하는 스크립트를 추가하셔서 활용해보시면 좋겠습니다.
"scripts": {
"tsc": "tsc --noEmit"
}
|
|
||
| const root = ReactDOM.createRoot(document.getElementById('root')); | ||
| const root = ReactDOM.createRoot( | ||
| document.getElementById('root') as HTMLElement, |
Collaborator
There was a problem hiding this comment.
"as" 키워드로 type assertion 하셨군요. 👍
type assertion을 사용하면, 타입추론을 덮어쓸 수 있으니, 타입에러는 피할 수 있지만, 런타임에, 즉 동작중에는 충분히 다른값이 들어갈 수 있습니다. 주의해주세요
Comment on lines
+46
to
+47
| <ItemTitle>{getProduct.name}</ItemTitle> | ||
| <ItemPrice>{getProduct.price.toLocaleString()}원</ItemPrice> |
Collaborator
There was a problem hiding this comment.
참조가 없어서 렌더링, 빌드자체가 안되고 있습니다ㅠ 개발서버에서 동작하는지 확인해주세요
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
요구사항
기본
심화
주요 변경사항
sprint7 에 타입스크립트 적용했습니다. 처음에 타입스크립트 템플릿 파일에 가지고 와서 했습니다.
스크린샷
멘토에게