Closed
🐛 fix(ci): separate tag and branch triggers in test-features workflow#261
Conversation
Establishes foundational CI workflow structure for automated devcontainer feature testing following production best practices from research (#241). Changes: - Created .github/workflows/test-features.yml - Configured triggers: - Push to main (paths: .devcontainer/features/**) - Pull requests (paths: .devcontainer/features/**) - Version tags (v*) when binary releases happen - Manual workflow_dispatch for ad-hoc testing - Set up OS matrix testing (Ubuntu 22.04, 24.04) - Added Dev Container CLI installation - Included feature discovery step - Added placeholder for actual test implementation Implementation Notes: This workflow establishes the CI structure and triggers. Subsequent tasks from parent issue #240 will implement the actual testing: - #248: Dev Container CLI-based feature installation testing - #249: OS distribution matrix testing (already scaffolded) - #250: Smoke tests to verify langstar command - #251: Feature metadata linting Research Reference: Based on devcontainers/features CI patterns documented in: reference/research/241-devcontainer-feature-ci-testing/ devcontainer-feature-ci-testing-best-practices-2025-11-22.md (lines 66-90) Fixes #247 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Separate tag trigger from branch trigger to fix path filter issue - Add documentation comment explaining unused features output - Add error handling for missing/empty features directory Addresses Copilot review comments in PR #260 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Copilot
AI
changed the title
[WIP] Create automated testing workflow for devcontainer features
🐛 fix(ci): separate tag and branch triggers in test-features workflow
Nov 24, 2025
Base automatically changed from
codekiln/247-create-automated-testing-workflow
to
codekiln/240-implement-automated-ci-testing
November 24, 2025 12:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses review feedback on the test-features workflow trigger configuration and error handling.
Changes
Fixed trigger logic (
.github/workflows/test-features.yml)pathsfilter applied to both branches and tags, preventing tag-triggered runs since tags don't have associated file changesmainnow trigger only on feature file changesv*) always trigger to validate feature compatibility with releasesAdded error handling for feature discovery
.devcontainer/featuresdirectory existence before scanningDocumentation improvements
featuresoutput is scaffolded for future PRs (240.2-devcontainer-feature Implement Dev Container CLI Testing #248, 240.4-devcontainer-feature Create Automated Smoke Tests #250, 240.5-devcontainer-feature Add Feature Metadata Linting #251)Related
Addresses review comments from #260
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.