✨ feat: add pre-release validation tests to release workflow - #268
Merged
Conversation
Add comprehensive pre-release validation job that runs full lifecycle deployment test before creating releases. This quality gate ensures the complete deployment workflow (create, update, delete) works correctly before publishing releases. Changes: - Add pre-release-validation job to release.yml - Run test_deployment_workflow_full_lifecycle before release creation - Configure 45-minute timeout (test takes ~20-30 minutes) - Require LANGSMITH_API_KEY and LANGSMITH_WORKSPACE_ID secrets - Block release if validation fails - Update CI/CD documentation with new workflow step The test validates: - Creating fresh deployment with unique name - Waiting for deployment to be READY - Patching deployment (triggers new revision) - Waiting for new revision to be DEPLOYED - Deleting deployment (cleanup via DeploymentGuard) Fixes #207 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a comprehensive pre-release validation step to the release workflow that runs a full deployment lifecycle test before creating releases. This quality gate ensures the SDK's deployment functionality (create, update, delete) works correctly before publishing any release.
- Added a
pre-release-validationjob that runs a ~20-30 minute integration test - Updated job dependencies so releases only proceed after validation passes
- Documented the new validation step in CI/CD documentation
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/release.yml |
Added pre-release-validation job with 45-minute timeout that runs full lifecycle deployment test; updated create-release job to depend on validation |
docs/dev/ci-cd.md |
Documented new pre-release validation step including timeout, duration, required secrets, and its role as a quality gate |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
codekiln
commented
Nov 24, 2025
| run: | | ||
| cargo test --test integration_deployment_workflow \ | ||
| test_deployment_workflow_full_lifecycle -- \ | ||
| --ignored --nocapture |
Owner
Author
There was a problem hiding this comment.
@copilot what does --ignored --nocapture do here?
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add comprehensive pre-release validation job that runs full lifecycle deployment test before creating releases. This quality gate ensures the complete deployment workflow (create, update, delete) works correctly before publishing releases.
Changes
Added
pre-release-validationjob to.github/workflows/release.ymlcreate-releasejob as a quality gatetest_deployment_workflow_full_lifecyclefrom SDK testsLANGSMITH_API_KEYandLANGSMITH_WORKSPACE_IDUpdated job dependencies
create-releasenow depends on bothverify-ciandpre-release-validationUpdated CI/CD documentation (
docs/dev/ci-cd.md)What the Test Validates
The full lifecycle test validates the complete deployment workflow:
Workflow Flow
Related Issues
Fixes #207
Part of epic #195 (new-release-ci milestone)
Test Plan
sdk/tests/integration_deployment_workflow.rsNext Steps
Before release, verify:
LANGSMITH_API_KEYsecret is configured in repositoryLANGSMITH_WORKSPACE_IDsecret is configured in repositoryv0.4.4-alpha.1) to verify end-to-endBenefits
🤖 Generated with Claude Code