Skip to content

✨ feat(assistant): add description field support from Agent Server API - #726

Merged
codekiln merged 2 commits into
mainfrom
m12-i725-featassistant-add-description-field-support-from-a
Jan 22, 2026
Merged

✨ feat(assistant): add description field support from Agent Server API#726
codekiln merged 2 commits into
mainfrom
m12-i725-featassistant-add-description-field-support-from-a

Conversation

@codekiln

@codekiln codekiln commented Jan 22, 2026

Copy link
Copy Markdown
Owner

Summary

Implements support for the description field from the LangSmith Agent Server API in both SDK and CLI.

Changes

SDK (sdk/src/assistants.rs)

  • Add description: Option<String> to Assistant struct
  • Add description: Option<String> to CreateAssistantRequest struct
  • Add description: Option<String> to UpdateAssistantRequest struct
  • Update unit tests to include description field
  • Update integration tests to include description field

CLI (cli/src/commands/assistant.rs)

  • Add --description flag to assistant create command
  • Add --description flag to assistant update command
  • Add "description" to available columns for text output
  • Display description in assistant get command output
  • Update ColumnMetadata::render_tsv to handle description column

API Specification

According to the Agent Server API docs:

  • Type: string | null
  • Required: No (optional field)
  • Description: "The description of the assistant"

Test Plan

  • Code compiles (cargo check)
  • Clippy passes (cargo clippy)
  • Unit tests updated and pass
  • Integration tests updated (existing tests modified to include description field)
  • Integration tests for description CRUD operations (to be added in follow-up)

Related Issues

Fixes #725


🤖 Generated with Claude Code

Add description field to Assistant SDK structs and CLI commands per Agent Server API spec.

SDK changes:
- Add description: Option<String> to Assistant struct
- Add description to CreateAssistantRequest
- Add description to UpdateAssistantRequest
- Update unit tests to include description field
- Update integration tests to include description field

CLI changes:
- Add --description flag to assistant create command
- Add --description flag to assistant update command
- Add description to ASSISTANT_COLUMNS for text output
- Display description in get command output
- Update ColumnMetadata to render description in TSV

Fixes #725

Co-Authored-By: Claude <noreply@anthropic.com>
@codekiln codekiln added this to the ls-cli-output-dx milestone Jan 22, 2026
Copilot AI review requested due to automatic review settings January 22, 2026 21:07
@github-actions

github-actions Bot commented Jan 22, 2026

Copy link
Copy Markdown
Contributor

Unit Test Results

186 tests  ±0   186 ✅ ±0   1s ⏱️ ±0s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 7246fbe. ± Comparison against base commit 47eb92a.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Jan 22, 2026

Copy link
Copy Markdown
Contributor

SDK Integration Test Results

294 tests  ±0   294 ✅ ±0   32s ⏱️ -15s
 13 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 7246fbe. ± Comparison against base commit 47eb92a.

♻️ This comment has been updated with latest results.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements support for the description field from the LangSmith Agent Server API, enabling users to add descriptive text to assistants for better documentation and discovery.

Changes:

  • Added description: Option<String> field to SDK Assistant structs (Assistant, CreateAssistantRequest, UpdateAssistantRequest)
  • Added --description flag to CLI create and update commands for assistants
  • Enhanced CLI output to display description in get command and include it as an available column for text output

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
sdk/src/assistants.rs Added optional description field to Assistant, CreateAssistantRequest, and UpdateAssistantRequest structs with proper serialization attributes; updated unit tests
sdk/tests/assistant_integration_test.rs Updated integration test requests to include description field (set to None for existing tests)
cli/src/commands/assistant.rs Added --description flag to create/update commands, added description to available columns, implemented display logic for get command, and updated TSV rendering

@github-actions

github-actions Bot commented Jan 22, 2026

Copy link
Copy Markdown
Contributor

Integration Test Results

316 tests  +1   316 ✅ +1   5m 49s ⏱️ +42s
 13 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 7246fbe. ± Comparison against base commit 47eb92a.

♻️ This comment has been updated with latest results.

…n field

Adds SDK and CLI integration tests for assistant description field support:

SDK Integration Tests (sdk/tests/assistant_integration_test.rs):
- test_assistant_description_field: Full CRUD lifecycle with description
  - Create assistant WITH description
  - Verify description in GET response
  - Update description
  - Verify update persisted
  - Test clearing description (None handling)
  - Cleanup with DELETE

CLI Integration Tests (cli/tests/assistant_command_test.rs):
- test_assistant_description_field: Full CLI workflow with description
  - Create with --description flag
  - Verify description in JSON output
  - GET and verify description
  - UPDATE description via --description flag
  - Verify update persisted
  - Check description appears in text output (stderr)

Testing Standards:
- Follows CRUD lifecycle pattern (docs/dev/testing/crud-lifecycle-pattern.md)
- Uses SDK to verify CLI actions persisted correctly
- Verifies actual behavior, not just exit codes
- Uses unique test names (microsecond timestamp + UUID)
- Proper cleanup in all test paths
- Marked with #[cfg_attr(not(feature = "integration-tests"), ignore)]

All 610 workspace tests pass.

Related to #725

Co-Authored-By: Claude <noreply@anthropic.com>
@codekiln
codekiln merged commit 4a57ccb into main Jan 22, 2026
14 checks passed
@codekiln
codekiln deleted the m12-i725-featassistant-add-description-field-support-from-a branch January 22, 2026 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

✨ feat(assistant): add description field support from Agent Server API

2 participants