Skip to content

Added prelude.rs for both v1_6 and v2_0_1 (Used in tests) #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

hlsxx
Copy link

@hlsxx hlsxx commented May 7, 2025

I’m suggesting this PR because I believe using preludes can be helpful in certain scenarios, including mine 🙂

I’ve also updated tests/schema_validation to reflect how these preludes are used—hope you find it useful!

use crate::v2_0_1::datatypes::prelude::*;
use crate::v2_0_1::enumerations::prelude::*;
use crate::v2_0_1::messages::prelude::*;

@tommymalmqvist
Copy link
Member

Nice! Will approve in a couple of days. Need to spend some time on #165 right now

@hlsxx
Copy link
Author

hlsxx commented May 8, 2025

Sure, man!

Copy link

codecov bot commented May 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.99%. Comparing base (6c82ba5) to head (f5cf9d1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #166   +/-   ##
=======================================
  Coverage   93.99%   93.99%           
=======================================
  Files         189      189           
  Lines       31456    31456           
=======================================
  Hits        29568    29568           
  Misses       1888     1888           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tommymalmqvist
Copy link
Member

Want to add support for the new v2_1? @hlsxx

@hlsxx
Copy link
Author

hlsxx commented May 21, 2025

Sure, I'd be happy to.

@tommymalmqvist
Copy link
Member

Sure, I'd be happy to.

Build is failing

@hlsxx
Copy link
Author

hlsxx commented May 21, 2025

Sure, I'd be happy to.

Build is failing

Sure, I'd be happy to.

Build is failing

I'm not done yet, I just commit some changes but I will work on that today or tomorrow ;)

@tommymalmqvist
Copy link
Member

Sure, I'd be happy to.

Build is failing

Sure, I'd be happy to.

Build is failing

I'm not done yet, I just commit some changes but I will work on that today or tomorrow ;)

Just checking 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants