Add ResponseBuilder to build status line #6
Conversation
emilsoman
commented
Nov 17, 2013
emilsoman
commented
- Response class to encapsulate response data
* Response class to encapsulate response data
| end | ||
|
|
||
| def set_status_line(status) | ||
| http_version = @response.http_version |
There was a problem hiding this comment.
generally it is a good idea to use the accessor outside the initialize function. ie. response rather than @response
although, in microbenchmarks @response will have better performance than response
There was a problem hiding this comment.
In terms of communication, I like to think that @attribute says "i'm an instance variable" where as the accessor method says "looks like somebody has set an accessor for an instance variable by my name, but double check just to be sure" . For that reason I prefer using @attribute inside the class and the accessor method on objects of the class .
There was a problem hiding this comment.
sounds good. off topic: one concern that i have using @attribute is, its hard to catch typos. i can mistype it as @attribtue and it still works most of the places.
There was a problem hiding this comment.
do not have a strong opinion here.
but for object-oriented code. acccessors are almost always a good idea. because we can mixin code.
do not think it says much for code "communication" but that is just me
