Skip to content

Fix windows workflow #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
codemasher merged 2 commits into from
Sep 12, 2025
Merged

Fix windows workflow #10

codemasher merged 2 commits into from
Sep 12, 2025

Conversation

@shivammathur
Copy link

@shivammathur shivammathur commented Sep 12, 2025

This PR

  • Fixes windows builds with PHP 7.4 as liblzma_a.lib is only available in vs16 and newer builds, in vc15 it is liblzma.lib.
  • Fixes a failing test.

@shivammathur shivammathur changed the title Ext xz Fix windows workflow Sep 12, 2025
@codemasher
Copy link
Owner

codemasher commented Sep 12, 2025

Thank you so much for the fixes!

@codemasher codemasher merged commit 94c8bb7 into codemasher:main Sep 12, 2025
24 checks passed
@codemasher codemasher mentioned this pull request Sep 12, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shivammathur @codemasher