Skip to content

refactor: simplify devcontainer configuration and remove workspace mount #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ThomasK33
Copy link
Member

@ThomasK33 ThomasK33 commented Aug 7, 2025

Simplify DevContainer Configuration

This PR streamlines the DevContainer setup by:

  1. Standardizing indentation in the Dockerfile for better readability
  2. Removing unnecessary workspace directory setup in the Dockerfile
  3. Removing custom mount configuration in devcontainer.json
  4. Improving formatting in devcontainer.json for better readability

These changes simplify the DevContainer configuration while maintaining the core functionality of the Nix-based development environment.

@ThomasK33 ThomasK33 marked this pull request as ready for review August 7, 2025 19:49
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ThomasK33 ThomasK33 force-pushed the thomask33/refactor_simplify_devcontainer_setup_by_removing_post-create_script branch from 24500ab to 96b76e7 Compare August 7, 2025 20:37
@ThomasK33 ThomasK33 changed the title refactor: simplify devcontainer setup by removing post-create script refactor: simplify devcontainer configuration and remove workspace mount Aug 7, 2025
Change-Id: I6eed81bdda7f09f6a6ebe010ed2d6ed50366700f
Signed-off-by: Thomas Kosiewski <[email protected]>
@ThomasK33 ThomasK33 force-pushed the thomask33/refactor_simplify_devcontainer_setup_by_removing_post-create_script branch from 96b76e7 to f0d99eb Compare August 7, 2025 20:44
Copy link
Member Author

ThomasK33 commented Aug 8, 2025

Merge activity

  • Aug 8, 6:53 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Aug 8, 6:53 AM UTC: @ThomasK33 merged this pull request with Graphite.

@ThomasK33 ThomasK33 merged commit 1489c70 into main Aug 8, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant