Skip to content

Update Code to 1.102.0 #7418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update Code to 1.102.0 #7418

wants to merge 2 commits into from
+53 −63

Conversation

benz0li
Copy link
Contributor

@benz0li benz0li commented Jul 11, 2025

Fixes #7414

@benz0li benz0li requested a review from a team as a code owner July 11, 2025 05:01
@benz0li
Copy link
Contributor Author

benz0li commented Jul 11, 2025

@code-asher Please review:

Applying patch patches/display-language.diff
patching file lib/vscode/src/vs/server/node/serverServices.ts
Hunk #2 succeeded at 267 with fuzz 2 (offset 12 lines).
patching file lib/vscode/src/vs/platform/environment/common/environmentService.ts
Hunk #1 succeeded at 98 (offset -3 lines).
patching file lib/vscode/src/vs/server/node/remoteLanguagePacks.ts
patching file lib/vscode/src/vs/server/node/webClientServer.ts
patching file lib/vscode/src/vs/server/node/serverEnvironmentService.ts
Hunk #1 succeeded at 21 (offset 2 lines).
Hunk #2 succeeded at 110 (offset 2 lines).
patching file lib/vscode/src/vs/platform/languagePacks/browser/languagePacks.ts
can't find file to patch at input line 251
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|Index: code-server/lib/vscode/src/vs/workbench/services/localization/electron-sandbox/localeService.ts
|===================================================================
|--- code-server.orig/lib/vscode/src/vs/workbench/services/localization/electron-sandbox/localeService.ts
|+++ code-server/lib/vscode/src/vs/workbench/services/localization/electron-sandbox/localeService.ts
--------------------------
No file to patch.  Skipping patch.
2 out of 2 hunks ignored
patching file lib/vscode/src/vs/workbench/contrib/extensions/browser/extensionsActions.ts
patching file lib/vscode/build/gulpfile.reh.js
Hunk #1 FAILED at 58.
1 out of 1 hunk FAILED -- saving rejects to file lib/vscode/build/gulpfile.reh.js.rej
patching file lib/vscode/src/vs/workbench/workbench.web.main.internal.ts
Applied patch patches/display-language.diff (forced; needs refresh)

@benz0li
Copy link
Contributor Author

benz0li commented Jul 11, 2025

Killed: https://github.com/coder/code-server/actions/runs/16212208388/job/45774334711#step:11:512

@code-asher Please rerun.

@benz0li
Copy link
Contributor Author

benz0li commented Jul 11, 2025

Local build:

npm run build:vscode
> [email protected] build:vscode
> ./ci/build/build-vscode.sh

Updated 0 paths from the index

> [email protected] gulp
> node --max-old-space-size=8192 --optimize-for-size ./node_modules/gulp/bin/gulp.js vscode-reh-web-linux-x64-min

[06:59:09] Using gulpfile ~/projects/coder/code-server/lib/vscode/gulpfile.js
[06:59:09] Starting 'vscode-reh-web-linux-x64-min'...
[06:59:09] Starting clean-out-build ...
[06:59:09] Finished clean-out-build after 3 ms
[06:59:09] Starting build-date-file ...
[06:59:09] Finished build-date-file after 1 ms
[06:59:09] Starting compile-api-proposal-names ...
[06:59:09] Starting compilation api-proposal-names...
(node:20774) [DEP0180] DeprecationWarning: fs.Stats constructor is deprecated.
(Use `node --trace-deprecation ...` to show where the warning was created)
[06:59:09] Finished compilation api-proposal-names with 0 errors after 94 ms
[06:59:09] Finished compile-api-proposal-names after 106 ms
[06:59:09] Starting compile-src ...
[06:59:41] [mangler] Done collecting. Classes: 9026. Exported symbols: 11040
[06:59:45] [mangler] Done creating class replacements
[06:59:45] [mangler] Starting prepare rename edits
[06:59:47] Starting compilation...
[07:25:41] [mangler] Done preparing edits: 4539 files
[07:25:57] [mangler] Done: 5568.63kb saved, memory-usage: {"total_heap_size":2460643328,"total_heap_size_executable":9150464,"total_physical_size":2457845760,"total_available_size":6169903880,"used_heap_size":2385333176,"heap_size_limit":8593080320,"malloced_memory":3189008,"peak_malloced_memory":20058864,"does_zap_garbage":0,"number_of_native_contexts":1,"number_of_detached_contexts":0,"total_global_handles_size":5390336,"used_global_handles_size":2119616,"external_memory":112260207}
[07:34:53] Error: /home/benz0li/projects/coder/code-server/lib/vscode/src/vs/workbench/workbench.web.main.internal.ts(56,8): Cannot find module './services/localization/electron-sandbox/localeService.js' or its corresponding type declarations.
[07:34:53] Finished compilation with 1 errors after 2105643 ms
[07:34:53] Error: /home/benz0li/projects/coder/code-server/lib/vscode/src/vs/workbench/workbench.web.main.internal.ts(56,8): Cannot find module './services/localization/electron-sandbox/localeService.js' or its corresponding type declarations.
[07:34:53] Finished compilation with 1 errors after 2105643 ms
[07:34:53] 'vscode-reh-web-linux-x64-min' errored after 36 min
[07:34:53] Error: Found 1 errors
    at Stream.<anonymous> (/home/benz0li/projects/coder/code-server/lib/vscode/build/lib/reporter.js:94:29)
    at _end (/home/benz0li/projects/coder/code-server/lib/vscode/node_modules/through/index.js:65:9)
    at stream.end (/home/benz0li/projects/coder/code-server/lib/vscode/node_modules/through/index.js:74:5)
    at Stream.onend (node:internal/streams/legacy:48:10)
    at Stream.emit (node:events:530:35)
    at Stream.emit (node:domain:552:15)
    at drain (/home/benz0li/projects/coder/code-server/lib/vscode/node_modules/through/index.js:34:23)
    at stream.queue.stream.push (/home/benz0li/projects/coder/code-server/lib/vscode/node_modules/through/index.js:45:5)
    at Stream.end (/home/benz0li/projects/coder/code-server/lib/vscode/node_modules/through/index.js:15:35)
    at _end (/home/benz0li/projects/coder/code-server/lib/vscode/node_modules/through/index.js:65:9)

@benz0li
Copy link
Contributor Author

benz0li commented Jul 11, 2025

Modified <path>/<to>/electron-sandbox/localeService.js to <path>/<to>/electron-browser/localeService.js in patches/display-language.diff.

@benz0li
Copy link
Contributor Author

benz0li commented Jul 11, 2025

Error: The operation was canceled: https://github.com/coder/code-server/actions/runs/16213635217/job/45778236635?pr=7418#step:11:512

@code-asher Please rerun.

@benz0li
Copy link
Contributor Author

benz0li commented Jul 11, 2025

code-server-4.102.0-rc.1-linux-amd64.tar.gz with Code 1.102.0 is deployed at https://coder.jupyter.b-data.ch.

Functionality [modified by patches] tested and found to work:

  • base-path
  • cli-window-open
  • local-storage
  • marketplace
  • proxy-url
  • service-worker
  • web view

Workspaces and Jupyter Notebooks also work fine:

@benz0li
Copy link
Contributor Author

benz0li commented Jul 14, 2025

@code-asher Please rerun Build / Build code-server (pull_request) and check what is going wrong.

@benz0li
Copy link
Contributor Author

benz0li commented Jul 14, 2025

@code-asher My local build was successful and is deployed at https://coder.jupyter.b-data.ch.

@code-asher
Copy link
Member

code-asher commented Jul 14, 2025 •
edited
Loading

Weird, not sure why it keeps canceling. I would guess it is hitting the 60 minute timeout except it seems to be canceling far earlier than that...investigating...maybe it is OOM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Code to 1.102
2 participants
@benz0li @code-asher