🤖 ci: add Codex PR loop tooling for agents#6
Conversation
|
@codex review Please review the PR for correctness and workflow fit for this Go repo. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e7116deab2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review Addressed the two review findings:
Please take another look. |
Bring over mux pull-request skill and supporting scripts into this Go repo, then adapt them for coder-k8s workflows. - add PR skill at .mux/skills/pull-requests/SKILL.md - add Codex/PR scripts under scripts/ - add scripts/wait_pr_ready.sh wrapper for one-command Codex+CI waiting - add project AGENTS.md guidance (non-TypeScript sections adapted for Go) - add codex-comments job to .github/workflows/ci.yaml Validation: - bash -n scripts/*.sh - actionlint .github/workflows/ci.yaml - make verify-vendor - make test - make build --- _Generated with `mux` • Model: `openai:gpt-5.3-codex` • Thinking: `xhigh` • Cost: `$0.82`_ <!-- mux-attribution: model=openai:gpt-5.3-codex thinking=xhigh costs=0.82 -->
- paginate Codex comment + review thread queries in check_codex_comments.sh - paginate review threads in check_pr_reviews.sh - treat numeric input as PR when it resolves in extract_pr_logs.sh Validation: - bash -n scripts/*.sh - make verify-vendor - make test - make build --- _Generated with `mux` • Model: `openai:gpt-5.3-codex` • Thinking: `xhigh` • Cost: `$0.82`_ <!-- mux-attribution: model=openai:gpt-5.3-codex thinking=xhigh costs=0.82 -->
ThomasK33
force-pushed
the
agents-vtxz
branch
from
594331d to
4641be5
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 594331d32c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Handle PRs with more than 100 comments/review threads by paginating the GraphQL fetches in wait_pr_codex.sh. Validation: - bash -n scripts/*.sh - make verify-vendor - make test - make build --- _Generated with `mux` • Model: `openai:gpt-5.3-codex` • Thinking: `xhigh` • Cost: `$0.82`_ <!-- mux-attribution: model=openai:gpt-5.3-codex thinking=xhigh costs=0.82 -->
|
@codex review Addressed the pagination gap in Please re-review. |
|
Codex Review: Didn't find any major issues. 👍 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Summary
This PR ports the mux pull-request workflow tooling into
coder-k8s, adapted for a Go/Kubernetes controller repository.Background
We want agents in this repo to follow a strict PR lifecycle:
Implementation
.mux/skills/pull-requests/SKILL.mdwith this repo's validation commands (make verify-vendor,make test,make build) and explicit Codex loop discipline.scripts/:wait_pr_checks.shwait_pr_codex.shcheck_codex_comments.shresolve_pr_comment.shcheck_pr_reviews.sh(adapted to dynamically resolve owner/repo)extract_pr_logs.sh(adapted for dynamic owner/repo and Go-oriented repro hints)scripts/wait_pr_ready.shas a one-command orchestrator (Codex -> CI) for end-of-workflow waiting.AGENTS.mdwith non-TypeScript guidance adapted from mux and a required Codex review loop..github/workflows/ci.yamlwith a PR-onlycodex-commentsjob to fail when unresolved Codex feedback remains.Validation
bash -n scripts/*.shgo run github.com/rhysd/actionlint/cmd/actionlint@v1.7.10 .github/workflows/ci.yamlmake verify-vendormake testmake buildRisks
Low-to-moderate process risk: this PR mostly adds tooling and instructions, but the new CI
codex-commentsgate can block merges if bot comments are unresolved or if the GitHub API is transiently unavailable.Generated with
mux• Model:openai:gpt-5.3-codex• Thinking:xhighGenerated with
mux• Model:openai:gpt-5.3-codex• Thinking:xhigh• Cost:$0.82