Skip to content

feat(codersdk): add ReducedWorkspace #17245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

johnstcn
Copy link
Member

@johnstcn johnstcn commented Apr 3, 2025

Adds a new type codersdk.ReducedWorkspace which is a subset of codersdk.Workspace. I picked the default fields from the coder list command.

Copy link
Member

@Emyrk Emyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the use case for this?

@johnstcn
Copy link
Member Author

johnstcn commented Apr 8, 2025

What is the use case for this?

Originally to support #17246 as the JSON includes a lot of tokens. However I'm investigating an alternative approach.

@Emyrk
Copy link
Member

Emyrk commented Apr 8, 2025

What is the use case for this?

Originally to support #17246 as the JSON includes a lot of tokens. However I'm investigating an alternative approach.

Ping me if you want my eyes later 👍

@mafredri
Copy link
Member

mafredri commented Apr 9, 2025

Originally to support #17246 as the JSON includes a lot of tokens. However I'm investigating an alternative approach.

Likewise, happy to review once we've settled on an approach (unassigning for now).

@mafredri mafredri removed their request for review April 9, 2025 16:42
@johnstcn johnstcn closed this Apr 9, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Apr 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants