fix: use background ssh channel for link handler #497
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After some investigation into the interaction with the Jetbrains plugin and coder/coder I found a bug where 2 ssh sessions labeled with `jetbrains` for the usage app were being open. We only want to use the main hostname when we want to track user activity, so for any background processes we should be using the background hostname.
Qodana Community for JVM3 new problems were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked View the detailed Qodana reportTo be able to view the detailed Qodana report, you can either:
To get - name: 'Qodana Scan'
uses: JetBrains/[email protected]
with:
upload-result: trueContact Qodana teamContact us at [email protected]
|
|
@f0ssel I'm not sure why this never got merged, but since it's a one liner and the code has changed completely out from under it I'm going to close it. We can validate if this is still a bug and fix it with a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of coder/coder#15176
After some investigation into the interaction with the Jetbrains plugin and coder/coder I found a bug where 2 ssh sessions labeled with
jetbrainsfor the usage app were being open. We only want to use the main hostname when we want to track user activity, so for any background processes we should be using the background hostname.