create DigitalOcean region module #221
Open
+378
−61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yaodingyd - can you please submit of a video of this working in a Coder deployment |
matifali
reviewed
Jul 20, 2025
| display_name: DigitalOcean Region | ||
| description: Provides a region selection parameter for DigitalOcean resources | ||
| icon: ../../../../.icons/digitalocean.svg | ||
| maintainer_github: coder |
There was a problem hiding this comment.
Suggested change
| maintainer_github: coder |
no more needed
matifali
reviewed
Jul 20, 2025
Comment on lines
+81
to
+90
| ## Variables | ||
|
|
||
| | Variable | Type | Default | Description | | ||
| | -------------- | -------- | ------------------------------------------------------------ | ---------------------------------------------------------- | | ||
| | `default` | `string` | `"ams3"` | The default region to select | | ||
| | `mutable` | `bool` | `false` | Whether the region can be changed after workspace creation | | ||
| | `name` | `string` | `"region"` | The name of the parameter | | ||
| | `display_name` | `string` | `"Region"` | The display name of the parameter | | ||
| | `description` | `string` | `"This is the region where your workspace will be created."` | The description of the parameter | | ||
| | `icon` | `string` | `"/emojis/1f30e.png"` | The icon to display for the parameter | |
There was a problem hiding this comment.
Remove this section as we already parse and render Variables on the registry frontend.
Comment on lines
+149
to
+155
| ## Benefits | ||
|
|
||
| 1. **Standardization**: Consistent region selection across all DigitalOcean templates | ||
| 2. **Maintenance**: Single place to update region options | ||
| 3. **User Experience**: Better UX with descriptive names and icons | ||
| 4. **Reliability**: Only includes regions that support required features | ||
| 5. **Flexibility**: Customizable for different use cases |
There was a problem hiding this comment.
Suggested change
| ## Benefits | |
| 1. **Standardization**: Consistent region selection across all DigitalOcean templates | |
| 2. **Maintenance**: Single place to update region options | |
| 3. **User Experience**: Better UX with descriptive names and icons | |
| 4. **Reliability**: Only includes regions that support required features | |
| 5. **Flexibility**: Customizable for different use cases |
Remove this section
| | `nyc1` | United States (New York - 1) | 🇺🇸 | | ||
| | `nyc3` | United States (New York - 3) | 🇺🇸 | | ||
|
|
||
| > **Note**: Some regions (nyc1, sfo1, ams2) are excluded because they do not support volumes, which are commonly used for persistent data storage. |
There was a problem hiding this comment.
Can we instead add an additional input to control getting only the regiosn with volumes?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #45
/claim #45
Description
Type of Change
Module Information
Path:
registry/[namespace]/modules/[module-name]New version:
v1.0.0Breaking change: [ ] Yes [ ] No
Testing & Validation
bun test)bun run fmt)Related Issues