Skip to content

feat: set 'vscode_connection' as build reason on workspace start #550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

kacpersaw
Copy link

This PR is part of coder/coder#18827 which introduces new build reason values to identify what type of connection triggered a workspace build, helping to troubleshoot workspace-related issues.

@kacpersaw kacpersaw changed the title Set 'vscode_connection' as build reason on workspace start feat: set 'vscode_connection' as build reason on workspace start Jul 14, 2025
@kacpersaw kacpersaw marked this pull request as ready for review July 15, 2025 13:04
@kacpersaw kacpersaw requested a review from ethanndickson July 15, 2025 13:04
Copy link
Member

@ethanndickson ethanndickson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming you've tested it against your feature branch with --reason

@@ -29,5 +30,10 @@ export function featureSetForVersion(
wildcardSSH:
(version ? version.compare("2.19.0") : -1) >= 0 ||
version?.prerelease[0] === "devel",

// --reason flag was added in 2.25.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// --reason flag was added in 2.25.0
// The --reason flag was added to `coder start` in 2.25.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants