Show Remote SSH Output panel on workspace start #627
Conversation
EhabY
force-pushed
the
show-remote-ssh-output-on-start
branch
from
bbb0391 to
92b1788
Compare
EhabY
force-pushed
the
show-remote-ssh-output-on-start
branch
2 times, most recently
from
719de6f to
fe6d1dc
Compare
EhabY
force-pushed
the
show-remote-ssh-output-on-start
branch
from
e3c9e7f to
ae04b2c
Compare
…tial ones beforehand
EhabY
force-pushed
the
show-remote-ssh-output-on-start
branch
from
ae04b2c to
ad6ea8c
Compare
EhabY
force-pushed
the
show-remote-ssh-output-on-start
branch
from
ad6ea8c to
bc4ba72
Compare
| this.maybeNotifyOutdated(workspace); | ||
| this.maybeNotifyAutostop(workspace); | ||
| this.maybeNotifyDeletion(workspace); |
There was a problem hiding this comment.
Was thinking about this some more, and we probably want to skip the deletion notification while in the setup phase too, otherwise I think we would get one notification here, and then another from the error thrown during setup.
Autostop and outdated I think are OK to show even during setup.
| case "stopping": | ||
| // Clear the agent ID since it could change after a restart | ||
| this.agentId = undefined; | ||
| progress?.report({ message: "Waiting for workspace build..." }); |
There was a problem hiding this comment.
What do you think about putting the build state in here? Waiting for workspace build: stopping or Waiting for workspace to queue/start/stop if we want to be fancy.
| case "starting": | ||
| case "stopping": | ||
| // Clear the agent ID since it could change after a restart | ||
| this.agentId = undefined; |
There was a problem hiding this comment.
I think we need to clear the agent socket here as well or something, when I stop my workspace and it starts again, I do not see the agent script logs the second time.
Or, maybe we clear the socket when the agent closes, or both.
2 participants
Closes #626