[mafredri]

This change adds experimental support for WebSockets over HTTP/2 (RFC 8441).

Implementation notes:

• To avoid breaking any flows, HTTP/2 functionality is currently opt-in on both server and client
• The HTTP/2 tests are currently kept in internal/thirdparty/http2 (they require importing golang.org/x/net/http2, see net/http: move HTTP/2 into std golang/go#67810)
• HTTP/2 extended CONNECT must currently be enabled via GODEBUG, see net/http: add support for SETTINGS_ENABLE_CONNECT_PROTOCOL golang/go#53208
• Explicit selection of HTTP/1 or HTTP/2 is required during Dial because we cannot test the underlying transport for support (for instance, http.Transport does not allow setting the HTTP/2 pseudo-header :protocol)
• To Dial with HTTP/2 support, a http2.Transport must be provided via DialOptions.Client (since we do not import golang.org/x/net/http2)
• There are a few changes and cleanups unrelated to this feature, if needed they can be broken out into a separate branch

Closes #4

---

This change does not yet include benchmark tests for HTTP/2, those will be added at a later date as a follow-up.

[code-asher]

Very nice 🤌 I messed around with the example as well and it all looks good.

[mtojek]

Amazing skills 👍 👍

Have you tried to establish a connection using other tools? JS possibly?

[mtojek]

This model will work until one day we will need to switch to HTTP3.99 :)

[mafredri]

ProtocolHTTP3_99 😂

[mtojek]

Should we support http.UnencryptedHTTP2?

[mafredri]

I did not know about this, I'll need to investigate. Thanks for the heads up 👍🏻

[mafredri]

I looked into this. Server-side already works with native h2c since the code checks r.ProtoMajor == 2, which handles both approaches the same way. The GODEBUG=http2xconnect=1 env is still needed though.

Client-side is the main issue. I tested Go 1.25, and the native http.Transport still rejects the :protocol pseudo-header, so the http2.Transport from x/net is needed.

Looks like full stdlib support is targeted for Go 1.26 (golang/go#67810), we can revisit then.

[code-asher]

Have you tried to establish a connection using other tools? JS possibly?

While I was testing I experimented with connecting to the server example from a JS (Node) client. Here is what I used for anyone interested (needs ws).

const http2 = require("http2")
const { Receiver, Sender } = require("ws")

const client = http2.connect("http://127.0.0.1:8080")

const req = client.request({
 ":method": "CONNECT",
 ":protocol": "websocket",
 ":scheme": "http",
 ":path": "/",
 ":authority": "127.0.0.1",
 "Sec-WebSocket-Key": "AQIDBAUGBwgJCgsMDQ4PEC==",
 "Sec-WebSocket-Version": "13",
})

req.on("response", (headers) => {
 console.log("status:", headers[":status"])
})

req.on("error", (err) => {
 console.log("error:", err)
})

const receiver = new Receiver()
receiver.on("message", (data) => {
 console.log("got message:", data.toString())
})

req.on("data", (chunk) => {
 receiver.write(chunk)
})

setInterval(() => {
 const sender = new Sender(req)
 sender.send("hey", { binary: false, mask: true, fin: true })
}, 1000)

sample output:

status: 200
got message: hey
got message: hey
got message: hey

[ambyjkl]

sec-websocket-key and sec-websocket-accept are not part of WebSocket HTTP/2 as per RFC 8441

https://datatracker.ietf.org/doc/html/rfc8441#:~:text=Implementations%20using%20this%20extended%20CONNECT%20to%20bootstrap%20WebSockets%0A%20%20%20do%20not%20do%20the%20processing%20of%20the%20Sec%2DWebSocket%2DKey%20and%20Sec%2DWebSocket%2D%0A%20%20%20Accept%20header%20fields%20of%20%5BRFC6455%5D%20as%20that%20functionality%20has%20been%0A%20%20%20superseded%20by%20the%20%3Aprotocol%20pseudo%2Dheader%20field.

[mafredri]

Thanks for catching this @ambyjkl!

[Nek-12]

Are there plans to ship this?

[mafredri]

@Nek-12 yes, absolutely! This fell on the back-burner but I will take another look at it next week.

[ybaldus]

@mafredri With go 1.27 x/net/http2 moved into the standard library. It might be worth to relook into the changes. See: https://pkg.go.dev/golang.org/x/net/http2#section-readme

I would be interested in the http2 websocket server. Do you need any help to ship this?