[8.2.0] Always run Turbine native image with a UTF-8 code page on Windows #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are building Turbine native images with a UTF-8 code page and need to match the runtime code page for UTF-8 paths to be handled properly. This change splits the existing tool for patching the app manifest of the embedded JDK into separate tools for reading and writing app manifests. The write tool is then used to add a manifest to the turbine binary. Closes bazelbuild#25444. PiperOrigin-RevId: 735457536 Change-Id: Id6395435cc350772e1225ecb80fa32a74f6ae0e3
|
@hvadehra Could you please take a look at the presubmit errors? Thanks! |
|
/refacto-test |
|
Refacto is reviewing this PR. Please wait for the review comments to be posted. |
![refacto-test[bot]](https://avatars.githubusercontent.com/u/196302493?s=60&v=4){kind=small}
| return 1; | ||
| } | ||
| DWORD manifest_len = SizeofResource(exe, manifest_resource); | ||
|
|
There was a problem hiding this comment.
Resource Management: The code doesn't check return values for UnlockResource and FreeResource calls, which could lead to resource leaks in error conditions. While these Windows API functions typically don't fail when properly initialized, it's best practice to add error handling:
// Add error checking for resource release
if (!UnlockResource(manifest_handle)) {
fwprintf(stderr, L"Warning: Failed to unlock resource: %d\n", GetLastError());
}
if (!FreeResource(manifest_handle)) {
fwprintf(stderr, L"Warning: Failed to free resource: %d\n", GetLastError());
}
|
/refacto-test |
|
Refacto is reviewing this PR. Please wait for the review comments to be posted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are building Turbine native images with a UTF-8 code page and need to match the runtime code page for UTF-8 paths to be handled properly. This change splits the existing tool for patching the app manifest of the embedded JDK into separate tools for reading and writing app manifests. The write tool is then used to add a manifest to the turbine binary.
Closes bazelbuild#25444.
PiperOrigin-RevId: 735457536
Change-Id: Id6395435cc350772e1225ecb80fa32a74f6ae0e3
Commit bazelbuild@0ede723